Feat: enable signAllTransactions for Ingame & External walllets #236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current implementation of
SignAllTransactions
in the Solana.Unity-SDK is incomplete and inefficient, causing issues when signing multiple transactions simultaneously. Additionally, the SDK contains redundant code paths, including outdated Phantom wallet integration that is no longer maintained.Solution
This PR enhances the
SignAllTransactions
method by:VersionedTransaction
andTransaction
types, making it more robust for different transaction versions.Additionally, as part of a refactor:
Before & After Screenshots
BEFORE:
Inefficient handling of multiple transactions in
SignAllTransactions
AFTER:
Improved
SignAllTransactions
method with efficient handling of multiple transactions and signature validationOther changes (e.g. bug fixes, small refactors)
GetSignatureForAddress
method to retrieve signatures for specific public keys.Deploy Notes
This PR introduces breaking changes by removing the Phantom-specific wallet integrations. Projects relying on Phantom in WebGL will need to migrate to the updated wallet adapter system, which now offers enhanced support for multiple transactions.
New dependencies: None