Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SignAllTransactions Method Across All Wallet Integrations in Solana.Unity-SDK #235

Closed
owais-star opened this issue Oct 15, 2024 · 0 comments

Comments

@owais-star
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Yes, the SignAllTransactions method is currently unimplemented across almost all wallet integrations in the Solana.Unity-SDK. This lack of implementation creates a significant gap for developers who need to sign multiple transactions at once. It forces manual handling of this process, leading to inefficiencies, increased complexity, and potential errors.

Describe the solution you'd like
I would like to see the SignAllTransactions method fully implemented across all supported wallet integrations (WebGL, mobile, etc.). This solution should include:

  • Batch transaction signing functionality.
  • Signature deduplication, prioritizing non-empty signatures.
  • Full support for VersionedTransaction and Transaction deserialization to ensure compatibility across different transaction types in Solana.

Describe alternatives you've considered
One alternative we are considering is switching to an updated fork of the SDK that includes these changes. This would allow us to bypass the limitations of the current version and use a more up-to-date version with the necessary transaction signing functionality in place.

Another alternative would be to manually implement the signing logic for multiple transactions, but this would be inefficient and would not scale well for complex use cases.

Additional context
The absence of this feature significantly limits the utility of the SDK for handling multiple transactions. Additionally, this issue could be an opportunity to clean up outdated integrations, such as the deprecated Phantom WebGL support, and focus on implementing key features for wallets that are actively maintained. Moving forward, either enhancing this functionality within the SDK or adopting a better-maintained fork will be essential.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@owais-star and others