This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
Tier prices - Add note to clarify discount calculation #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An admin must run tests on this PR before it can be merged. |
|
Hey @ihor-sviziev. Thank you for submitting the clarification. I'd like to take your information and adjust it slightly. I'd like to move the note to the end of step 2, where the user is defining the percent. I'd like to reword step 2. would you agree with this change?
|
hickskenh
added
Minor update
|
@hickskenh sure, I don't mind |
|
@ihor-sviziev Thanks for the speedy reply. i should be able to run tests and get this live today. |
hickskenh
removed
the
Waiting for response
hickskenh
changed the title
|
running tests |
hickskenh
approved these changes
Feb 13, 2020
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Dec 6, 2021
Merge master after fixing conflicts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) adds clarification that tier prices are calculated on top of "Price" field and not using "Special price".
Affected documentation pages
Affected Magento editions
Links to Magento source code or PRs
Additional information
We had discussion with @Nazar65 about fixing the issue magento/magento2#26583
There were two options:
Fix the calculated percentage on the product page on top of existing behavior in the admin + document it <-- that's why I created this PR
Change calculation of tier prices to be working with special prices.
During discussion we found that 2nd option will affect too many magento installations that working with tier prices, so decided to go with 1st option.