Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product Detail Page - Tier price (fixed & discount) save percentage displaying wrong calculation #26583

Closed
srsathish92 opened this issue Jan 29, 2020 · 11 comments
Assignees
Labels
Area: Frontend Component: Pricing Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@srsathish92
Copy link
Contributor

Tier price (fixed & discount) save percentage displaying wrong calculation in product detail page.

Preconditions (*)

  1. Magento 2.4-develop

Steps to reproduce (*)

  1. Create simple product with
    Price - $100.00
    Special price - $65.00
  2. Add tier price rule
    For 2 (Qty) - Fixed $40.00
    For 3 (Qty) - Percentage 36%
  3. Save the product.

Expected result (*)

Both fixed and discount save percentage should be applied on final price

  • Buy 2 for $40.00 each and save 38%
  • Buy 3 for $64.00 each and save 2%

Actual result (*)

Fixed price save percentage applied on final price (In our case special price) and Discount save percentage applied on base price.

  • Buy 2 for $40.00 each and save 38%
  • Buy 3 for $64.00 each and save 36%

tier_price_rule

@m2-assistant
Copy link

m2-assistant bot commented Jan 29, 2020

Hi @srsathish92. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@srsathish92 do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jan 29, 2020
@ghost ghost assigned srsathish92 Jan 29, 2020
@krishprakash krishprakash self-assigned this Jan 30, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 30, 2020

Hi @krishprakash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@krishprakash
Copy link

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @krishprakash. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @krishprakash, here is your Magento instance.
Admin access: https://i-26583-2-4-develop.instances.magento-community.engineering/admin_9af1
Login: 02b8101b Password: b06c0c655279
Instance will be terminated in up to 3 hours.

@krishprakash krishprakash added Area: Frontend Component: Pricing Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Jan 30, 2020
@ghost ghost unassigned krishprakash Jan 30, 2020
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jan 30, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @krishprakash
Thank you for verifying the issue. Based on the provided information internal tickets MC-30912 were created

Issue Available: @krishprakash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@srsathish92 srsathish92 added the Progress: PR Created Indicates that Pull Request has been created to fix issue label Jan 31, 2020
@ihor-sviziev
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, here is your Magento instance.
Admin access: https://i-26583-2-4-develop.instances.magento-community.engineering/admin_2fac
Login: 26678bd9 Password: 08ff719378b5
Instance will be terminated in up to 3 hours.

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Feb 12, 2020

We had discussion with @Nazar65 about fixing this issue.

There were two options:

  1. Fix the calculated percentage on the product page on top of existing behavior in the admin + document it

  2. Change calculation of tier prices to be working with special prices.

During discussion we found that 2nd option will affect too many magento installations that working with tier prices, so decided to go with 1st option.

What was done:

  1. Created fix for calculated percentage on the product page - #26583 Tier pricing save percent showing logic updated in product detail page #26584
  2. Created adjustment for documentation that tier prices doesn't work with special prices - Tier prices - Add note to clarify discount calculation merchdocs#338

Both changes still not merged, but I believe they'll be merged soon

@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Feb 21, 2020
magento-engcom-team added a commit that referenced this issue Feb 21, 2020
…n product detail page #26584

 - Merge Pull Request #26584 from srsathish92/magento2:bug/26583-pdp-tier-price-save-percent
 - Merged commits:
   1. 9c11369
   2. 00317ef
   3. ecc4ef5
   4. 24b3fba
   5. 62f8c6c
   6. 0110496
   7. 4680f70
magento-engcom-team added a commit that referenced this issue Feb 21, 2020
…n product detail page #26584

 - Merge Pull Request #26584 from srsathish92/magento2:bug/26583-pdp-tier-price-save-percent
 - Merged commits:
   1. 9c11369
   2. 00317ef
   3. ecc4ef5
   4. 24b3fba
   5. 62f8c6c
   6. 0110496
   7. 4680f70
   8. 0216e5e
@magento-engcom-team magento-engcom-team added the Reported on 2.4.0 Indicates original Magento version for the Issue report. label Nov 13, 2020
This was referenced May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Component: Pricing Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Development

No branches or pull requests

4 participants