Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Regions for Uruguay. #29722

Merged
merged 3 commits into from
Sep 30, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed code style. Changed DataInstallerFactory FQDN by Import.
  • Loading branch information
barbanet committed Sep 6, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 37675cc73c68c1ceefe2d2deef6b6588356f2cde
21 changes: 13 additions & 8 deletions app/code/Magento/Directory/Setup/Patch/Data/AddDataForUruguay.php
Original file line number Diff line number Diff line change
@@ -9,11 +9,12 @@
namespace Magento\Directory\Setup\Patch\Data;

use Magento\Directory\Setup\DataInstaller;
use Magento\Directory\Setup\DataInstallerFactory;
use Magento\Framework\Setup\ModuleDataSetupInterface;
use Magento\Framework\Setup\Patch\DataPatchInterface;

/**
* Class AddDataForUruguay
* Add Uruguay States/Regions
*/
class AddDataForUruguay implements DataPatchInterface
{
@@ -23,24 +24,24 @@ class AddDataForUruguay implements DataPatchInterface
private $moduleDataSetup;

/**
* @var \Magento\Directory\Setup\DataInstallerFactory
* @var DataInstallerFactory
*/
private $dataInstallerFactory;

/**
* @param ModuleDataSetupInterface $moduleDataSetup
* @param \Magento\Directory\Setup\DataInstallerFactory $dataInstallerFactory
* @param DataInstallerFactory $dataInstallerFactory
*/
public function __construct(
ModuleDataSetupInterface $moduleDataSetup,
\Magento\Directory\Setup\DataInstallerFactory $dataInstallerFactory
DataInstallerFactory $dataInstallerFactory
) {
$this->moduleDataSetup = $moduleDataSetup;
$this->dataInstallerFactory = $dataInstallerFactory;
}

/**
* @inheritdoc
* @return $this|AddDataForUruguay
*/
public function apply()
{
@@ -50,14 +51,16 @@ public function apply()
$this->moduleDataSetup->getConnection(),
$this->getDataForUruguay()
);

return $this;
}

/**
* Uruguay states data.
*
* @return array
*/
private function getDataForUruguay()
private function getDataForUruguay(): array
{
return [
['UY', 'UY-AR', 'Artigas'],
@@ -84,8 +87,9 @@ private function getDataForUruguay()

/**
* @inheritdoc
* @return array
*/
public static function getDependencies()
public static function getDependencies(): array
{
return [
InitializeDirectoryData::class,
@@ -94,8 +98,9 @@ public static function getDependencies()

/**
* @inheritdoc
* @return array
*/
public function getAliases()
public function getAliases(): array
{
return [];
}