Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Regions for Uruguay. #29722

Merged
merged 3 commits into from
Sep 30, 2020
Merged

Add Regions for Uruguay. #29722

merged 3 commits into from
Sep 30, 2020

Conversation

barbanet
Copy link
Member

@barbanet barbanet commented Aug 23, 2020 •
edited by engcom-Bravo
Loading

Description (*)

Regions for Uruguay will be added with this PR. Regions are using the ISO 3166-2 code (the regions table can be check here https://en.wikipedia.org/wiki/ISO_3166-2:UY)

Manual testing scenarios (*)

  1. Once you finish the installation the country should show you Regions on shipping estimation, checkout or when you edit the customer address form.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Add Regions for Uruguay. #29729: Add Regions for Uruguay.

@m2-assistant
Copy link

m2-assistant bot commented Aug 23, 2020

Hi @barbanet. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@BarnyShergold BarnyShergold self-assigned this Aug 23, 2020
@BarnyShergold
Copy link

@magento run all tests

BarnyShergold
BarnyShergold requested changes Aug 24, 2020
View reviewed changes
Copy link

@BarnyShergold BarnyShergold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure all tests are passing as well as requested changes

app/code/Magento/Directory/Setup/Patch/Data/AddDataForUruguay.php Outdated Show resolved Hide resolved
app/code/Magento/Directory/Setup/Patch/Data/AddDataForUruguay.php Show resolved Hide resolved
app/code/Magento/Directory/Setup/Patch/Data/AddDataForUruguay.php Show resolved Hide resolved
app/code/Magento/Directory/Setup/Patch/Data/AddDataForUruguay.php Outdated Show resolved Hide resolved
app/code/Magento/Directory/Setup/Patch/Data/AddDataForUruguay.php Show resolved Hide resolved
@sidolov sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 24, 2020
@sidolov
Copy link
Contributor

sidolov commented Aug 24, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Aug 24, 2020
Closed
@barbanet
Copy link
Member Author

Thank you @BarnyShergold for all those recommendations. I'll take care ASAP.

@VladimirZaets VladimirZaets self-assigned this Aug 26, 2020
@engcom-Echo engcom-Echo self-assigned this Sep 3, 2020
@engcom-Echo
Copy link
Contributor

Hi, @barbanet. Could you please check failed tests and recommendations?

Thank you.

@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Echo
Copy link
Contributor

Hi @barbanet. Can you fix "Static Tests"?
Failed functional tests not related to the changes in this PR

@gabrieldagama
Copy link
Contributor

The risk was set tolow due to: the suggested changes shouldn't impact other areas.

@engcom-Echo
Copy link
Contributor

@magento run all tests

engcom-Bravo
engcom-Bravo requested changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@engcom-Bravo engcom-Bravo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @BarnyShergold

Can you please add an appropriate label for test coverage?

Thank you

@ghost ghost dismissed BarnyShergold’s stale review September 23, 2020 09:13

Pull Request state was updated. Re-review required.

@magento-engcom-team
Copy link
Contributor

Hi @BarnyShergold, thank you for the review.
ENGCOM-8244 has been created to process this Pull Request
✳️ @BarnyShergold, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@BarnyShergold BarnyShergold added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 24, 2020
@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

Regions are added for Uruguay country

See the result BEFORE switching to the PR
29722_before

and AFTER switching to the PR
29722_after1

List of regions
29722_after2

Storefront
29722_storefront

✔️ Successfully submitted order and created shipment to Uruguay

@engcom-Bravo engcom-Bravo added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Sep 25, 2020
magento-engcom-team pushed a commit that referenced this pull request Sep 30, 2020
@sidolov
ENGCOM-8244: Add Regions for Uruguay. #29722
fa95e33
@magento-engcom-team magento-engcom-team merged commit 7a48783 into magento:2.4-develop Sep 30, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 30, 2020

Hi @barbanet, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Bravo engcom-Bravo engcom-Bravo requested changes

@BarnyShergold BarnyShergold BarnyShergold approved these changes

Assignees

@BarnyShergold BarnyShergold

@VladimirZaets VladimirZaets

@engcom-Bravo engcom-Bravo

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Directory Partner: Blue Acorn iCi partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Risk: low Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Add Regions for Uruguay.
8 participants
@barbanet @BarnyShergold @sidolov @engcom-Echo @gabrieldagama @magento-engcom-team @engcom-Bravo @VladimirZaets