Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve cc expire date issue for place order test #26653

Conversation

chiragp-wagento
Copy link

Description (*)

Resolved issue shown on https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/26418/20dfcf2ca6ca85d501a8a4de1c36b27a/Functional/allure-report-b2b/index.html#categories/5d53377627e2cd0919196717600acffc/144673bf8452e0f8/
place order test failed due to past expiration date for cc.

Related Pull Requests

#26418

Fixed Issues (if relevant)

  1. Compare Products section not showing in mobile view under 767px #26416: Compare Products section not showing in mobile view under 767px

Manual testing scenarios (*)

  1. Go to the Category page
  2. Add product to compare

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 2, 2020

Hi @chiragp-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner labels Feb 2, 2020
Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @chiragp-wagento. Thank you for your collaboration. There's another PR that includes the corresponding fix with correct values

https://github.com/magento/magento2/pull/26608/files

2040 is not supposed to be a correct value for the expiration year validator

@chiragp-wagento
Copy link
Author

Hi @rogyar,

You can check in my commit that I had changed the value to 2021 but @sivaschenko suggested to put future year. Kindly suggest what will be the next action item for this PR.

@sivaschenko
Copy link
Member

@chiragp-wagento thank you for your pull request! Looks like the fix for this issue has already been merged to 2.4-develop. So I have to close this pull request.

@m2-assistant
Copy link

m2-assistant bot commented Feb 11, 2020

Hi @chiragp-wagento, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Award: bug fix duplicate Event: mm20in Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: on hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants