Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fixed Compare Products section not showing in mobile view under 767px] #26418

Merged
merged 3 commits into from
Feb 21, 2020
Merged

[Fixed Compare Products section not showing in mobile view under 767px] #26418

merged 3 commits into from
Feb 21, 2020

Conversation

hitesh-wagento
Copy link
Contributor

Description (*)

Fixed Compare Products section not showing in mobile view under 767px

Fixed Issues (if relevant)

  1. Compare Products section not showing in mobile view under 767px #26416: Compare Products section not showing in mobile view under 767px

Manual testing scenarios (*)

  1. Go to the Category page
  2. Add product to compare

Expected result

expected

Actual result

actual

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 16, 2020

Hi @hitesh-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner labels Jan 16, 2020
@ghost ghost assigned ptylek Jan 16, 2020
@ptylek ptylek added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jan 16, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ptylek, thank you for the review.
ENGCOM-6622 has been created to process this Pull Request
✳️ @ptylek, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@hitesh-wagento hitesh-wagento added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Jan 17, 2020
@ptylek ptylek removed Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Jan 17, 2020
@ghost ghost assigned krzksz Jan 17, 2020
@magento-engcom-team
Copy link
Contributor

Hi @krzksz, thank you for the review.
ENGCOM-6622 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Jan 17, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Jan 17, 2020
@hitesh-wagento
Copy link
Contributor Author

Hello @magento-engcom-team

Is there any update in this PR ?

Thanks

@hitesh-wagento hitesh-wagento requested a review from ptylek January 28, 2020 07:45
@ptylek
Copy link
Contributor

ptylek commented Jan 28, 2020

Please wait @hitesh-wagento, PR is in progress

@magento-engcom-team
Copy link
Contributor

Hi @ptylek, thank you for the review.
ENGCOM-6622 has been created to process this Pull Request

@hitesh-wagento
Copy link
Contributor Author

Hello @magento-engcom-team

I have resolved conflicts

Thanks

@hitesh-wagento
Copy link
Contributor Author

#MM20IN

@hitesh-wagento
Copy link
Contributor Author

Hi @ptylek

How can I resolve Functional Tests error?

@chiragp-wagento chiragp-wagento mentioned this pull request Feb 2, 2020
Closed
4 tasks
@ptylek
Copy link
Contributor

ptylek commented Feb 4, 2020

Hi @hitesh-wagento, there are some changes being done to functional tests and I don't think that they are related to this PR. Please hold until this is solved.

@magento-engcom-team magento-engcom-team mentioned this pull request Feb 21, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Feb 21, 2020
@slavvka
ENGCOM-6622: [Fixed Compare Products section not showing in mobile vi…
3fac0b3 
…ew under 767px] #26418
@magento-engcom-team magento-engcom-team merged commit 5b4ce2f into magento:2.4-develop Feb 21, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 21, 2020

Hi @hitesh-wagento, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptylek ptylek ptylek approved these changes

@krzksz krzksz krzksz approved these changes

@sivaschenko sivaschenko Awaiting requested review from sivaschenko

Assignees

@krzksz krzksz

@ptylek ptylek

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Event: mm20in Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@hitesh-wagento @magento-engcom-team @engcom-Alfa @ptylek @krzksz @engcom-Charlie @engcom-Foxtrot @slavvka