26375 braintree payment address issue

[chris-pook]

Removing PrototypeJS dependency from this file which is the cause of issue #26375.

Description (*)

This may require further refactoring as it is not clear if/where the Prototype library is being used here. Either way Prototype shouldn't be required.

Fixed Issues (if relevant)

1. Switching billing address causes Javascript function text to render in front-end checkout payment section #26375

Manual testing scenarios (*)

As per issue #26375

1. Enable and configure Braintree module
2. Register a customer account
3. Add at least one address to the customer account
4. Add a product to cart
5. Go to checkout
6. Proceed to payment step
7. Untick "My billing and shipping address are the same"
8. Select an address from dropdown
9. Click "update"

Questions or comments

Need to ensure PrototypeJS is not being used in the file and if it is refactor to fully remove the dependency.

Contribution checklist (*)

• [ x ] Pull request has a meaningful description of its purpose
• [ x ] All commits are accompanied by meaningful commit messages
• [ x ] All new or changed code is covered with unit/integration tests (if applicable)
• [ x ] All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @chris-pook. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[m2-assistant]

Hi @chris-pook, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[chris-pook]

Says "Functional Tests EE" failed, however the report shows no failures. I've tried a re-run.

[chris-pook]

FYI these automated test checks seem pretty flaky. Had to re-run numerous times as they incorrectly reported failures.

[nuzil]

@magento give me test instance

[magento-engcom-team]

Hi @nuzil. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @nuzil, here is your new Magento instance.
Admin access: https://pr-26378.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[magento-engcom-team]

Hi @nuzil, thank you for the review.
ENGCOM-6606 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Before:

After:

[m2-assistant]

Hi @chris-pook, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.