Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address update at checkout shows some Weird thing #25684

Closed
bst2002git opened this issue Nov 21, 2019 · 11 comments
Closed

Address update at checkout shows some Weird thing #25684

bst2002git opened this issue Nov 21, 2019 · 11 comments
Labels
Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@bst2002git
Copy link

Preconditions (*)

Magento 2.3.3

Steps to reproduce (*)

Checkout change Customer Address on payment

Expected result (*)

Actual result (*)

I'v exactly this Result (with other Customer-Name)

https://magento.stackexchange.com/questions/293174/magento-2-3-3-address-update-at-checkout-shows-some-weird-thing
wired_thing_1
wired_thing_2

@m2-assistant
Copy link

m2-assistant bot commented Nov 21, 2019

Hi @bst2002git. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@bst2002git do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Nov 21, 2019
@bst2002git
Copy link
Author

@magento give me 2.3-develop instance - upcoming 2.3.x release

@magento-engcom-team
Copy link
Contributor

Hi @bst2002git. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @bst2002git, here is your Magento instance.
Admin access: https://i-25684-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@bst2002git
Copy link
Author

bst2002git commented Nov 21, 2019

Hmm, i'v imported some addresses into the develop instance to test (https://i-25684-2-3-develop.instances.magento-community.engineering/admin) and i can't see the file vendor/magento/magento2-base/lib/web/legacy-build.min.js being loaded. Which on my magento 2.3.3 installation is loaded and makes the wired thing...
When/Why is legacy-build.min.js be loaded?

@AnnaShepa
Copy link
Contributor

Hi @bst2002git I tried to reproduce the issue using the same address as on screenshot on test instance and on own environment (with the legacy-build.min.js file), but for me it still looks fine. Please check you js file and try to reproduce on clear magento. You can also check in dev tools some js erors

@achleitner
Copy link

achleitner commented Mar 4, 2020

Anyone got a solution for this`? Happening on Magento 2.3.4 Thanks

@bst2002git
Copy link
Author

Hello @achleitner ,
i've removed "prototype" from vendor/magento/module-braintree/view/frontend/web/js/view/payment/method-renderer/cc-form.js
see issue #26378

@achleitner
Copy link

achleitner commented Mar 4, 2020

Hello @achleitner ,
i've removed "prototype" from vendor/magento/module-braintree/view/frontend/web/js/view/payment/method-renderer/cc-form.js
see issue #26378

hey @bst2002git this works just perfectly! Many thanks! Should have checked github for a response 9 hours ago :)

@Eddcapone
Copy link

Eddcapone commented Nov 2, 2021

I have this issue in 2.4.2 Enterprise. There is no vendor/magento/module-braintree

@cdcrothers
Copy link

cdcrothers commented Nov 21, 2022

Issue still exists in 2.4.2-p2 Enterprise.

Caused by lib/web/legacy-build.min.js
which maps to prototype
which is depended on by Magento_GoogleTagManager/js/google-analytics-universal
which is depended on by vendor/magento/module-google-tag-manager/view/frontend/web/js/google-tag-manager-cart.js
which is injected by vendor/magento/module-google-tag-manager/view/frontend/templates/js.phtml
referenced by vendor/magento/module-google-tag-manager/view/frontend/layout/default.xml
which only happens when google/analytics/active is enabled

so enable it, and you'll reproduce the issue.

"prototype" is a lib that's been without support for 7+ years. This lib makes some seemingly very global changes to the array prototype. First glance, I'd bet the Enumerable object is being treated as an item in the street array for some reason. Seems like an underlying conflict with prototype.js, and another js library such as underscore or jquery.

The dependency on prototype.js within the GTM module seems to be a new change. I reviewed some older projects and didn't see it present. IIRC, those projects included some later 2.3.x versions, maybe a very early 2.4.x version.

The issue was introduced by 2687221
and was even mentioned in
#26276

The temporary fix is to apply the patch outlined in this comment: #26276 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Development

No branches or pull requests

6 participants