Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #25390 - UPS carrier model getting error when creating plugin in to Magento 2.3.3 compatibility #26130

Conversation

Bartlomiejsz
Copy link
Contributor

@Bartlomiejsz Bartlomiejsz commented Dec 19, 2019

Description (*)

This is fix for #25390

Fixed Issues (if relevant)

  1. UPS carrier model getting error when create plugin in to Magento 2.3.3 compatibility #25390: UPS carrier model getting error when create plugin in to Magento 2.3.3 compatibility

Manual testing scenarios (*)

Check fixed issue for steps explaination

Questions or comments

There are no changes to be tested here.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 19, 2019

Hi @Bartlomiejsz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-6523 has been created to process this Pull Request
✳️ @aleron75, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@aleron75 aleron75 added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Dec 27, 2019
@engcom-Charlie engcom-Charlie self-assigned this Dec 30, 2019
@engcom-Charlie
Copy link
Contributor

✔️ QA Passed

@engcom-Golf engcom-Golf self-assigned this Dec 30, 2019
@VladimirZaets VladimirZaets added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Dec 30, 2019
@Bartlomiejsz Bartlomiejsz changed the title Fix #25390 - UPS carrier model getting error when create plugin in to Magento 2.3.3 compatibility Fix #25390 - UPS carrier model getting error when creating plugin in to Magento 2.3.3 compatibility Jan 1, 2020
magento-engcom-team pushed a commit that referenced this pull request Jan 3, 2020
@magento-engcom-team magento-engcom-team merged commit cfd5c22 into magento:2.4-develop Jan 3, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 3, 2020

Hi @Bartlomiejsz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@Bartlomiejsz Bartlomiejsz deleted the feature/fix_25390_ups_carrier_constructor branch May 28, 2020 22:26
@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Ups Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants