-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPS carrier model getting error when create plugin in to Magento 2.3.3 compatibility #25390
Comments
Hi @Bhavik-kumar. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
For more details, please, review the Magento Contributor Assistant documentation. @Bhavik-kumar do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?
|
Hi @engcom-Charlie. Thank you for working on this issue.
|
✅ Confirmed by @engcom-Charlie Issue Available: @engcom-Charlie, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself. |
This will probably be fixed by #25181 |
…ier, cleanup of class imports
Hi @Bhavik-kumar. Thank you for your report. The fix will be available with the upcoming 2.4.0 release. |
… plugin in to Magento 2.3.3 compatibility #26130
is any one confirm that this is fixed with 2.3.4 ? |
@Bhavik-kumar I have replicated the issue on 2.3.5-p2 and fix is to run the |
Preconditions (*)
Magento 2.3.3 & 2.3-develop
with Developer mode.
Steps to reproduce (*)
Magento\Ups\Model\Carrier
with custom di.xmlapp/code/<vender>/<module>/etc/di.xml
Expected result (*)
Plugin should work properly with developer mode
Actual result (*)
Getting below error
As my understand issue is because of
Magento\Ups\Model\Carrier::__construct
last param should be null (newly added in to 2.3.3) $proxyDeferredFactory is not follow compatibilityThe text was updated successfully, but these errors were encountered: