Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Populate label elements for street address fields in checkout #22070

Conversation

amol2jcommerce
Copy link
Contributor

Original Pull Request

#21484

Description (*)

Populate <label> elements for the street fields in checkout. (The elements are already present but are blank by default.) This applies both when entering either a new shipping address or billing address.

The one aspect of this PR I'm not certain is handled the best way is the translation of the label. Glad to see any suggestions for improvements on how I've done this.

Fixed Issues (if relevant)

#10893: Street fields in checkout don't have a label that's readable by a screenreader

Manual testing scenarios (*)

  1. Add a product to your cart
  2. Go to checkout
  3. Verify that the street address fields have a linked <label> with text populated (e.g., "Street Address: Line 1"). These labels should be hidden visually (since meaning is implied visually by the fieldset legend) but accessible to screen reader software.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 31, 2019

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ghost ghost assigned rogyar Mar 31, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-4622 has been created to process this Pull Request

@soleksii
Copy link

soleksii commented Apr 4, 2019

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Apr 9, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants