Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Street fields in checkout don't have a label that's readable by a screenreader #10893

Closed
TomFranssen opened this issue Sep 15, 2017 · 9 comments
Assignees
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@TomFranssen
Copy link

TomFranssen commented Sep 15, 2017

Preconditions

  1. Standard Magento ver. 2.1.7 installation

Steps to reproduce

  1. Add a product to your cart
  2. Go to checkout

Expected result

  1. The labels should have a valid <label> element that is linked to the <input> field with a for attribute. My advice is to add linked elements to all the address line fields so that screen readers can know what kind of fields the address fields are and thus increasing accessibility.

Actual result

The address lines input fields don't have a <label> element with a valid value. There is a <span> infront of it with the text 'Address'. This text however doesn't get recognised by screen readers.

If I test this on the default MAC screenreader (activated by CMD + F5) I get the feedback of: 'edit text blank'. In this situation the visually impaired user doesn't get feedback on what type of field it is.

@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Sep 15, 2017
@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Sep 21, 2017
@patrikpihlstrom
Copy link

I can take a look at this later today if nobody else has claimed it.

@mzeis
Copy link
Contributor

mzeis commented Oct 7, 2017

@patrikpihlstrom Looks like the issue is yours!
[Update] Sorry, can't assign you to the issue, your name is not available in the selection.

@mzeis mzeis assigned mzeis and unassigned mzeis Oct 7, 2017
@okorshenko
Copy link
Contributor

Hi @patrikpihlstrom could you please accept the invitation on GitHub?

@bluemwhitew
Copy link
Contributor

Possibly related to #7428?

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 11, 2017
@scottsb scottsb self-assigned this Feb 26, 2019
@magento-engcom-team
Copy link
Contributor

Hi @scottsb. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@scottsb
Copy link
Member

scottsb commented Feb 26, 2019

@patrikpihlstrom Since this hasn't been touched in two years, I'm assuming you didn't reach a solution. 😆Taking this to work on.

@patrikpihlstrom
Copy link

@scottsb Go nuts!

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Mar 30, 2019
@magento-engcom-team
Copy link
Contributor

Hi @TomFranssen. Thank you for your report.
The issue has been fixed in #21484 by @scottsb in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.2 release.

@magento-engcom-team
Copy link
Contributor

Hi @TomFranssen. Thank you for your report.
The issue has been fixed in #22070 by @amol2jcommerce in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.9 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

7 participants