Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] #17163: Add meta NOINDEX,NOFOLLOW to admin scope to avoid accidental crawling #17263

Closed
wants to merge 1 commit into from
Closed

Conversation

mage2pratik
Copy link
Contributor

Original Pull Request

#17163

Description

On occasion the admin url may be leaked to the frontend. This can (and has) result in the admin URL being available in search engines. This provides easy targets for brute force/password guessing hacks.

This fix will add a meta tag which instructs Google and other friendly bots not to add the admin URL to search results.

Manual testing scenarios

Visit the admin panel and view the source code. The head section should contain

<meta name="robots" content="NOINDEX,NOFOLLOW"/>

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik
Thank you for your contribution. This pull request has been combined (merged) with #17260 to optimize pull requests queue on magento/magento2 repository
Closing this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants