Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Using interface instead of model directly #17260

Merged
merged 3 commits into from
Jul 30, 2018
Merged

[Backport] Using interface instead of model directly #17260

merged 3 commits into from
Jul 30, 2018

Conversation

mage2pratik
Copy link
Contributor

@mage2pratik mage2pratik commented Jul 29, 2018

Original Pull Request

#17124
#17263

Description

Using interface instead of model directly

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@sidolov
Copy link
Contributor

sidolov commented Jul 29, 2018

@magento-engcom-team combine 17263

@magento-engcom-team
Copy link
Contributor

Hi @sidolov. Thank you for your request. I'm working on combining the pull requests for you

@magento-engcom-team
Copy link
Contributor

@mage2pratik all pull requests have been successfully combined together:

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution.
We will aim to release these changes as part of 2.1.15.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants