Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.2] #6460: Add option to keep Files in Rollback #12585

Closed
wants to merge 1 commit into from

Conversation

osrecio
Copy link
Member

@osrecio osrecio commented Dec 7, 2017

Add option to keep files in rollback and improve Readability and PSR of Backup Library

Description

Ask to user when launch command: bin/magento setup:rollback if he wants keep files to future rollbacks. Also I changed variable name protected with underscore to acomplish PSR and I imported all classes to use in class.

Fixed Issues (if relevant)

  1. [2.1.1 CE] Rollback/Restore deletes database (--db) backup file in ${webroot}/var/backups. #6460: [2.1.1 CE] Rollback/Restore deletes database (--db) backup file in ${webroot}/var/backups.

Manual testing scenarios

  1. create backup e.g: bin/magento setup:backup --media
  2. rollback backup e.g: bin/magento setup:rollback -m 1508950479_filesystem_media.tgz
  3. Answer y to question: Do you want to keep the backups?[y/N]
  4. Check that your backup was kept in var/backups

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added bugfix Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Component: Setup SQUASHTOBERFEST labels Dec 7, 2017
@osrecio
Copy link
Member Author

osrecio commented Dec 12, 2017

Backport of: #11750 cc @dmanners

@osrecio
Copy link
Member Author

osrecio commented Dec 18, 2017

Closing this ticket, I don't find the solution to not break B/C

@osrecio osrecio closed this Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Component: Setup Progress: needs update Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants