Add option to keep Files in Rollback #11750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fooman
suggested changes
Oct 25, 2017
| foreach ($file as $statement) { | ||
| $this->getResourceModel()->runCommand($statement); | ||
| } | ||
| @unlink($source); | ||
| if ($this->keepSourceFile()) { |
There was a problem hiding this comment.
The logic seems to be reversed here and should be !$this->keepSourceFile()
There was a problem hiding this comment.
I will check tomorrow, maybe I was wrong copying between branches
magento-engcom-team
added
2.2.x
bugfix
Reproduced on 2.1.x
fooman
approved these changes
Nov 9, 2017
dmanners
suggested changes
Nov 11, 2017
| * | ||
| * @var boolean | ||
| */ | ||
| protected $keepSourceFile; |
| * @param boolean $keepSourceFile | ||
| * @return $this | ||
| */ | ||
| public function setKeepSourceFile($keepSourceFile) |
There was a problem hiding this comment.
Let's add a new interface for these methods.
There was a problem hiding this comment.
Added to SourceFileInterface
| * | ||
| * @return boolean | ||
| */ | ||
| public function keepSourceFile(); |
There was a problem hiding this comment.
Let's move these to a new interface.
There was a problem hiding this comment.
Added to SourceFileInterface
| @@ -127,7 +127,13 @@ protected function execute(InputInterface $input, OutputInterface $output) | |||
| if (!$helper->ask($input, $output, $question) && $input->isInteractive()) { | |||
| return \Magento\Framework\Console\Cli::RETURN_FAILURE; | |||
| } | |||
| $this->doRollback($input, $output); | |||
| $questionKeep = new ConfirmationQuestion( | |||
| '<info>you want to keep the backups?[y/N]<info>', | |||
There was a problem hiding this comment.
How about "Do you want to keep the backup files?" as the message here.
This was referenced Nov 11, 2017
…of Backup Library
osrecio
force-pushed
the
PR#KeepFilesRollback_2.3
branch
from
6f5b992 to
fd034dc
Compare
|
@dmanners Added changes, I hope everything are Ok ;-) |
dmanners
approved these changes
Nov 27, 2017
magento-team
pushed a commit
that referenced
this pull request
Nov 30, 2017
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to keep files in rollback and improve Readability and PSR of Backup Library
Description
Ask to user when launch command:
bin/magento setup:rollbackif he wants keep files to future rollbacks. Also I changed variable name protected with underscore to acomplish PSR and I imported all classes to use in class.Fixed Issues (if relevant)
Manual testing scenarios
bin/magento setup:backup --mediabin/magento setup:rollback -m 1508950479_filesystem_media.tgzyto question:you want to keep the backups?[y/N]var/backupsContribution checklist