Date incorrect on pdf invoice #26675

devchris79 · 2020-02-03T10:31:13Z

Preconditions (*)

Magento 2.4-develop

Steps to reproduce (*)

Go to Sales->Orders, select an order and then try to "print invoices"

Expected result (*)

Date to reflect purchase date

Actual result (*)

Dates are incorrect, we have 2006 and 2008 for orders, before the website was developed....
Dates were fine in 2.3.2.
#26665issueInvoice.pdf

magento-deployment-service · 2020-02-03T10:31:14Z

Thanks for opening this issue!

m2-assistant · 2020-02-03T10:31:15Z

Hi @devchris79. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@devchris79 do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

yes
no

Join Magento Community Engineering Slack and ask your questions in #github channel.

anvanza · 2020-02-03T13:08:45Z

Same issue here but my dates are way higher.

Maybe a good thing to note is the settings below:
Timezone Sever: UTC
Locale Storeview: nl_NL

m2-assistant · 2020-02-04T10:17:39Z

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
5. Add label Issue: Confirmed once verification is complete.
6. Make sure that automatic system confirms that report has been added to the backlog.

magento-deployment-service · 2020-02-04T11:19:53Z

Thanks for opening this issue!

magento-engcom-team · 2020-02-04T11:20:36Z

✅ Confirmed by @engcom-Delta
Thank you for verifying the issue. Based on the provided information internal tickets MC-31082 were created

Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

devchris79 · 2020-02-04T11:42:15Z

@engcom-Delta Why did you edit the post to include a precondition of Locale Storeview: nl_NL?
This is not a precondition that we used.....

It looks like the date is inserted in:
/vendor/magento/module-sales/Model/Order/Pdf/AbstractPdf.php

So this may affect other pdf documents like shipping, credit memo etc.

devchris79 · 2020-02-04T11:51:10Z

Credit memos are also affected.

devchris79 · 2020-02-04T13:37:15Z

I think this may be because of the changes in #23693. @edenduong does that sound likely?

magento-deployment-service · 2020-02-04T14:00:15Z

Thanks for opening this issue!

edenduong · 2020-02-04T14:27:14Z

Hi @devchris79 ,

Thank you for your issue report. I try to reproduce it on my local site but I can not reproduce in my site. In my commit, I try to change the logic of scopeDate similar to the date function. Before that, they are different and the scopeDate didn't support full type of interface.

engcom-Delta · 2020-02-04T14:32:54Z

@devchris79 According your steps as its are now, issue is not reproducible. comment adds more details to how reproduce issue and Locale=Dutch (Netherlands) is important thing to reproduce issue

anvanza · 2020-02-04T14:33:44Z

@magento give me 2.3-develop instance

magento-engcom-team · 2020-02-04T14:33:48Z

Hi @anvanza. Thank you for your request. I'm working on Magento 2.3-develop instance for you

devchris79 · 2020-02-04T14:37:38Z

Hi @edenduong

Why have you closed this issue? Its been seen by myself, @anvanza and @engcom-Delta

Here is our locale options:

edenduong · 2020-02-04T14:40:26Z

@devchris79 : sorry for my mistake. I didn’t mean that. I reopened it.

devchris79 · 2020-02-04T14:43:20Z

@edenduong No problem :-) Maybe the issue is related to the locale option giving the strange results. It seems @engcom-Delta and @anvanza believe this to be pertinent.

engcom-Delta · 2020-02-04T14:46:21Z

@magento give me 2.4-develop instance

gwharton · 2020-02-23T19:15:39Z

I don't know what Magento's plan is for backporting to 2.3. Presumably they are still going to be releasing 2.3.5 etc... so I would assume they will be handling the backporting internally, as we are no longer able to generate backports outside of the magento organisation.

In the meantime....

For each issue I care about, that has been merged into 2.4, I create a diff and apply it using the cweagans patching process to my 2.3 installation. At each version release of 2.3, I check each one in turn and if it has been backported into 2.3 by magento, then I remove my local patch. This way, I should be covered in both scenareos.

glastron174 · 2020-03-09T10:59:27Z

If you havent done so already, look into one of the composer patch management packages, then download the pull request as a diff, and apply via your main composer file. I think applying patches like this is preferred to editing core.

composer require cweagans/composer-patches
Add section to bottom of main composer.json file
    "extra": {
        "magento-force": "override",
        "composer-exit-on-patch-failure": true,
        "patches": {
            "magento/framework": {
                "1.0": "patches/composer/26701.diff"
            }
        }
    }
Download the patch from https://patch-diff.githubusercontent.com/raw/magento/magento2/pull/26701.diff and save into patches/composer folder

Edit the patch file and remove all "lib/internal/Magento/Framework/" from paths. so paths would be "a/Stdlib/DateTime/Timezone.php" and "b/Stdlib/DateTime/Timezone.php" etc.

Now just do a

composer install

When a new release is out which already incorporates the fix, then remove the patch from your composer file.

Hi, Should the /patches/composer folder created in the root?
I'm getting an error on the composer install

[Seld\JsonLint\ParsingException]
"./composer.json" does not contain valid JSON
Parse error on line 133:
}
--------------------^
Expected one of: '}', ','

Thanks in advanced, Edwin

gwharton · 2020-03-09T11:01:50Z

Looks like there is some whitespace on the end of line 133 that it doesn't like. There shouldnt be any whitespace at the ends of the lines in a json file. Probably just copy and pasted across.

and yes, the patches folder goes in the root of magento

gwharton · 2020-03-09T11:04:27Z

If it is working right, on composer install it should remove framework, reinstall framework and then apply the patch. Then you're good to go. Once the patch is integrated into mainline, you can remove it from your composer.json when you update.

glastron174 · 2020-03-09T11:31:51Z

If it is working right, on composer install it should remove framework, reinstall framework and then apply the patch. Then you're good to go. Once the patch is integrated into mainline, you can remove it from your composer.json when you update.

Thanks, I had to add one } extra in the sjon file. The dates in PDFs are correct now.

tushhan · 2020-05-28T16:06:13Z

I am using Magento 2.3.4

I have applied @edenduong' code to the file located in; /vendor/magento/framework/Stdlib/DateTime/Timezone.php (line 196)

###############

public function scopeDate($scope = null, $date = null, $includeTime = false)
{
$timezone = new \DateTimeZone(
$this->_scopeConfig->getValue($this->getDefaultTimezonePath(), $this->_scopeType, $scope)
);
switch (true) {
case (empty($date)):
$date = new \DateTime('now', $timezone);
break;
case ($date instanceof \DateTime):
case ($date instanceof \DateTimeImmutable):
$date = $date->setTimezone($timezone);
break;
default:
$date = new \DateTime(is_numeric($date) ? '@' . $date : $date);
$date->setTimezone($timezone);
break;
}

    if (!$includeTime) {
        $date->setTime(0, 0, 0);
    }

    return $date;
}

###################

This corects dates on invoices.

dudzio12 · 2020-06-01T14:20:40Z

If you use Magento with composer, there is a diff for you:
https://pastebin.com/YtzX09gL

ghost · 2020-06-04T12:56:48Z

@dudzio12
How can I apply this patch with composer?

If you use Magento with composer, there is a diff for you:
https://pastebin.com/YtzX09gL

dudzio12 · 2020-06-04T13:06:30Z

@JustICTNL:

composer require cweagans/composer-patches
Create root subdirectory called patches and create file `datetime_format_2_3_5.patch.
Add pastebin content to this file
Add to your composer.json:

(...)
 "extra": {
        "magento-force": "override",
        "enable-patching": true,
        "composer-exit-on-patch-failure": true,
        "patches": {
            "magento/framework": {
                "Datetime format": "patches/datetime_format_2_3_5.patch"
            }
        }
    }
}

MarcusWolschon · 2020-06-04T13:19:39Z

@JustICTNL:

1. `composer require cweagans/composer-patches`

2. Create root subdirectory called `patches` and create file `datetime_format_2_3_5.patch.

3. Add pastebin content to this file

4. Add to your composer.json:

(...)
 "extra": {
        "magento-force": "override",
        "enable-patching": true,
        "composer-exit-on-patch-failure": true,
        "patches": {
            "magento/framework": {
                "Datetime format": "patches/datetime_format_2_3_5.patch"
            }
        }
    }
}

Do we have to remove this again before upgrading to the next Magento release?
What steps are required (I have never worked with patches in Composer).

dudzio12 · 2020-06-04T13:24:44Z

You probably should delete it as soon as the new release implementing proper fix will be available.

It's good practise to name the patch with issue number just to not get lost in the future:

"magento/framework": {
  "Datetime format - Magento 2.3.5 - issue 26675": "patches/datetime_format_2_3_5_26675.patch"
 }

hostep · 2020-06-04T14:03:23Z

@MarcusWolschon: with composer-exit-on-patch-failure set to true, composer will complain if the patch is no longer applicable on a certain version of Magento, which is very handy.
But we always double check all our patches after every new Magento version anyways to make sure they are still needed or not (sometimes a fix is done in a completely different way than the patch and composer wouldn't complain in that case, but that's not happening very often)

ghost · 2020-06-04T14:41:43Z

@dudzio12 and @MarcusWolschon
I did what you said, but it doesn't work for me :'(

Did I do something wrong, or is there another solution? I had the order date 9-11-2022. In magento is the correct order date.

ghost · 2020-06-04T14:44:17Z

Magento directory/composer.json

"extra": {
        "magento-force": "override",
        "enable-patching": true,
        "composer-exit-on-patch-failure": true,
        "patches": {
            "magento/framework": {
                "Datetime format": "patches/datetime_format_2_3_5.patch"
            }
        },

DIFF file pasted in file:
Magento Directory/patches/datetime_format_2_3_5.patch

ghost · 2020-06-08T18:43:43Z

I am using Magento 2.3.4

I have applied @edenduong' code to the file located in; /vendor/magento/framework/Stdlib/DateTime/Timezone.php (line 196)

###############

public function scopeDate($scope = null, $date = null, $includeTime = false)
{
$timezone = new \DateTimeZone(
$this->_scopeConfig->getValue($this->getDefaultTimezonePath(), $this->_scopeType, $scope)
);
switch (true) {
case (empty($date)):
$date = new \DateTime('now', $timezone);
break;
case ($date instanceof \DateTime):
case ($date instanceof \DateTimeImmutable):
$date = $date->setTimezone($timezone);
break;
default:
$date = new \DateTime(is_numeric($date) ? '@' . $date : $date);
$date->setTimezone($timezone);
break;
}
    if (!$includeTime) {
        $date->setTime(0, 0, 0);
    }

    return $date;
}
###################

This corects dates on invoices.

This works now for me. i updgraded to Magento 2.3.5-P1 and now it works.
FInd the file with command:
find . -name Timezone.php
Result: ./vendor/magento/framework/Stdlib/DateTime/Timezone.php

I changed above in ./vendor/magento/framework/Stdlib/DateTime/Timezone.php
And now it works :)

IbrahimS2 · 2020-08-31T12:50:05Z

@magento-engcom-team It still persisting even on M2.3.5-p2, can we have this ported/merged to p3 maybe?

https://github.com/magento/magento2/blob/2.3.5-p2/lib/internal/Magento/Framework/Stdlib/DateTime/Timezone.php

VincentMarmiesse · 2020-10-16T09:55:36Z

This issue still exists in version 2.3.6.

FredericMartinez · 2020-10-19T17:34:28Z

Patch from https://github.com/magento/magento2/commit/5ebb43bb59b97f5315ae6421fe3c1b04c6affc70.patch do the job (on 2.3.5-p2)

LaurensGoedel · 2021-06-07T06:29:44Z

Just updated to 2.3.7 and issue still extists

hostep · 2021-06-07T07:17:36Z

@LaurensGoedel: the issue got fix in Magento 2.4.0 and above, it looks like Magento core devs didn't seem to think it was necessary to backport this fix to the 2.3.x release line. If you still need a fix for 2.3.x, please read through the entire thread, there are plenty of comments that tell you how to apply patches to resolve this issue.

Aquive · 2021-06-23T11:19:36Z

Still exists in M2.3.7. I used this fix: https://stackoverflow.com/questions/64553446/magento-2-3-4-wrong-order-date-in-invoice-pdf

magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Feb 3, 2020

engcom-Delta self-assigned this Feb 4, 2020

engcom-Delta added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Component: Sales Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Feb 4, 2020

ghost unassigned engcom-Delta Feb 4, 2020

magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Feb 4, 2020

edenduong closed this as completed Feb 4, 2020

edenduong reopened this Feb 4, 2020

This was referenced Mar 12, 2020

Error in forms with date inputs in german format #27265

Closed

Localized date field formatting in admin messing up actual date #27310

Closed

nelero mentioned this issue Mar 20, 2020

27027 added date format adjustment for 'validate-dob' rule #27149

Merged

4 tasks

cristienache mentioned this issue May 8, 2020

Magento 2.3.5 Wrong date on PDF invoice #28158

Closed

dudzio12 mentioned this issue Jun 1, 2020

Wrong date in order PDF fooman/printorderpdf-implementation-m2#7

Closed

ghost mentioned this issue Jun 4, 2020

Incorrect invoice date Magento 2.3.4 #28490

Closed

5 tasks

devchris79 mentioned this issue Oct 29, 2020

Invoice PDF shows wrong date (magento 2.3.6) #30697

Closed

1 task

magento-engcom-team added the Reported on 2.3.2 Indicates original Magento version for the Issue report. label Nov 13, 2020

sdzhepa mentioned this issue May 9, 2022

tyutyu sdzhepa/magento2#5

Open

Date incorrect on pdf invoice #26675

Date incorrect on pdf invoice #26675

Comments

devchris79 commented Feb 3, 2020 • edited Loading

Preconditions (*)

Steps to reproduce (*)

Expected result (*)

Actual result (*)

magento-deployment-service bot commented Feb 3, 2020

m2-assistant bot commented Feb 3, 2020

anvanza commented Feb 3, 2020 • edited Loading

m2-assistant bot commented Feb 4, 2020

magento-deployment-service bot commented Feb 4, 2020

magento-engcom-team commented Feb 4, 2020

devchris79 commented Feb 4, 2020

devchris79 commented Feb 4, 2020 • edited Loading

devchris79 commented Feb 4, 2020

magento-deployment-service bot commented Feb 4, 2020

edenduong commented Feb 4, 2020 • edited Loading

engcom-Delta commented Feb 4, 2020 • edited Loading

anvanza commented Feb 4, 2020

magento-engcom-team commented Feb 4, 2020

devchris79 commented Feb 4, 2020

edenduong commented Feb 4, 2020

devchris79 commented Feb 4, 2020

engcom-Delta commented Feb 4, 2020

gwharton commented Feb 23, 2020

glastron174 commented Mar 9, 2020

gwharton commented Mar 9, 2020 • edited Loading

gwharton commented Mar 9, 2020

glastron174 commented Mar 9, 2020

tushhan commented May 28, 2020

dudzio12 commented Jun 1, 2020

ghost commented Jun 4, 2020

dudzio12 commented Jun 4, 2020

MarcusWolschon commented Jun 4, 2020

dudzio12 commented Jun 4, 2020

hostep commented Jun 4, 2020

ghost commented Jun 4, 2020

ghost commented Jun 4, 2020 • edited by ghost Loading

ghost commented Jun 8, 2020

IbrahimS2 commented Aug 31, 2020 • edited Loading

VincentMarmiesse commented Oct 16, 2020

FredericMartinez commented Oct 19, 2020

LaurensGoedel commented Jun 7, 2021

hostep commented Jun 7, 2021

Aquive commented Jun 23, 2021

devchris79 commented Feb 3, 2020 •

edited

Loading

anvanza commented Feb 3, 2020 •

edited

Loading

devchris79 commented Feb 4, 2020 •

edited

Loading

edenduong commented Feb 4, 2020 •

edited

Loading

engcom-Delta commented Feb 4, 2020 •

edited

Loading

gwharton commented Mar 9, 2020 •

edited

Loading

ghost commented Jun 4, 2020 •

edited by ghost

Loading

IbrahimS2 commented Aug 31, 2020 •

edited

Loading