Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localized date field formatting in admin messing up actual date #27310

Closed
tdgroot opened this issue Mar 17, 2020 · 8 comments
Closed

Localized date field formatting in admin messing up actual date #27310

tdgroot opened this issue Mar 17, 2020 · 8 comments
Assignees
Labels
Component: Locale Component: SalesRule Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.3.3-p1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.

Comments

@tdgroot
Copy link
Member

tdgroot commented Mar 17, 2020

Preconditions (*)

  1. Magento >= 2.3.3-p1, 2.4-develop

Steps to reproduce (*)

  1. Have 2 admin users. One on locale en_US, one one nl_NL.
  2. Log in on nl_NL admin user.
  3. Create a cart price rule, no coupon code needed, just a simple cart price rule. Make sure you set the from date (e.g. 17 march 2020). Save the cart price rule.

Expected result (*)

  1. The saved from date is 17-03-2020.
    image

Actual result (*)

  1. The saved from date is 20-03-2017.
    image
@m2-assistant
Copy link

m2-assistant bot commented Mar 17, 2020

Hi @tdgroot. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@tdgroot do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@devchris79
Copy link

May be worth checking #26675

@tdgroot
Copy link
Member Author

tdgroot commented Mar 18, 2020

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @tdgroot. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Mar 26, 2020
@engcom-Alfa
Copy link
Contributor

The issue is reproducible on fresh 2.4-develop

Peek 2020-08-12 16-10

@engcom-Alfa engcom-Alfa added Component: Locale Component: SalesRule Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Aug 12, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-36668 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Aug 12, 2020
@sdzhepa sdzhepa added Priority: P3 May be fixed according to the position in the backlog. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Aug 13, 2020
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: ready for dev labels Sep 24, 2020
@ghost ghost removed the Progress: PR Created Indicates that Pull Request has been created to fix issue label Oct 23, 2020
Copy link

m2-assistant bot commented Jul 25, 2024

Hi @engcom-Delta. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

    1. Add/Edit Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
    1. If the issue is not relevant or is not reproducible any more, feel free to close it.

@engcom-Delta
Copy link
Contributor

Hi @tdgroot,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop and the issue is not reproducible. Saved date is set as expected. Kindly refer the screenshots.

Steps to Reproduce

  1. Create an admin user with nl_NL Interface Locale
    image
  2. Login as nederlands admin user.
  3. Create a cart price rule.
  4. Set From date as today's date and save cart price rule.
    image
  5. Observe set start date is displaying as expected in cart price rule list and detail page.
    image
    image
    Kindly recheck the issue on latest Magento 2.4-develop instance and Please let us know if you are still facing any issue.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Locale Component: SalesRule Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.3.3-p1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants