Skip to content

Commit

Permalink
ENGCOM-6364: [FIXES] #25674: Elasticsearch version selections in admi…
Browse files Browse the repository at this point in the history
…n are overly … #25838

 - Merge Pull Request #25838 from mautz-et-tong/magento2:fix-for-25674
 - Merged commits:
   1. cf1b084
   2. 37cf56d
  • Loading branch information
magento-engcom-team committed Dec 18, 2019
2 parents 9400c1e + 37cf56d commit 366ada1
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<test name="ProductQuickSearchUsingElasticSearchTest">
<annotations>
<features value="Search"/>
<stories value="Quick Search of products on Storefront when ES 5.0+ is enabled"/>
<stories value="Quick Search of products on Storefront when ES 5.x is enabled"/>
<title value="Product quick search doesn't throw exception after ES is chosen as search engine"/>
<description value="Verify no elastic search exception is thrown when searching for product before catalogsearch reindexing"/>
<severity value="CRITICAL"/>
Expand All @@ -36,7 +36,7 @@
</after>

<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
<comment userInput="Change Catalog search engine option to Elastic Search 5.0+" stepKey="chooseElasticSearch5"/>
<comment userInput="Change Catalog search engine option to Elastic Search 5.x" stepKey="chooseElasticSearch5"/>
<actionGroup ref="ChooseElasticSearchAsSearchEngine" stepKey="chooseES5"/>
<actionGroup ref="ClearPageCacheActionGroup" stepKey="clearing"/>
<actionGroup ref="updateIndexerBySchedule" stepKey="updateAnIndexerBySchedule">
Expand All @@ -57,4 +57,4 @@
<comment userInput="End of searching products" stepKey="endOfSearchingProducts"/>
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin2"/>
</test>
</tests>
</tests>
2 changes: 1 addition & 1 deletion app/code/Magento/Elasticsearch/etc/adminhtml/system.xml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
<comment><![CDATA[<a href="https://docs.magento.com/m2/ce/user_guide/catalog/search-elasticsearch.html">Learn more</a> about valid syntax.]]></comment>
<backend_model>Magento\Elasticsearch\Model\Config\Backend\MinimumShouldMatch</backend_model>
</field>
<!-- Elasticsearch 5.0+ -->
<!-- Elasticsearch 5.x -->
<field id="elasticsearch5_server_hostname" translate="label" type="text" sortOrder="61" showInDefault="1" showInWebsite="0" showInStore="0">
<label>Elasticsearch Server Hostname</label>
<depends>
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Elasticsearch/etc/di.xml
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@
<arguments>
<argument name="engines" xsi:type="array">
<item name="elasticsearch" xsi:type="string">Elasticsearch</item>
<item name="elasticsearch5" xsi:type="string">Elasticsearch 5.0+</item>
<item name="elasticsearch5" xsi:type="string">Elasticsearch 5.x</item>
</argument>
</arguments>
</type>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<entity name="SearchEngineElasticsearchConfigData">
<data key="path">catalog/search/engine</data>
<data key="scope_id">1</data>
<data key="label">Elasticsearch 6.0+</data>
<data key="label">Elasticsearch 6.x</data>
<data key="value">elasticsearch6</data>
</entity>
</entities>
2 changes: 1 addition & 1 deletion app/code/Magento/Elasticsearch6/etc/adminhtml/system.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<system>
<section id="catalog">
<group id="search">
<!-- Elasticsearch 6.0+ -->
<!-- Elasticsearch 6.x -->
<field id="elasticsearch6_server_hostname" translate="label" type="text" sortOrder="71"
showInDefault="1" showInWebsite="0" showInStore="0">
<label>Elasticsearch Server Hostname</label>
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Elasticsearch6/etc/di.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<type name="Magento\Search\Model\Adminhtml\System\Config\Source\Engine">
<arguments>
<argument name="engines" xsi:type="array">
<item name="elasticsearch6" xsi:type="string">Elasticsearch 6.0+</item>
<item name="elasticsearch6" xsi:type="string">Elasticsearch 6.x</item>
</argument>
</arguments>
</type>
Expand Down

0 comments on commit 366ada1

Please sign in to comment.