Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

120 implement store configs coverage #126

Merged
merged 7 commits into from
Jul 24, 2018
Merged

120 implement store configs coverage #126

merged 7 commits into from
Jul 24, 2018

Conversation

VitaliyBoyko
Copy link
Contributor

@VitaliyBoyko VitaliyBoyko commented Jul 18, 2018 •
edited
Loading

Description

Implemented StoreConfig graphql coverage

Fixed Issues (if relevant)

  1. Implement storeConfigs coverage #120: Implement storeConfigs coverage
{
  storeConfig{
        id,
    	code,
    	website_id,
    	locale,
    	base_currency_code,
    	default_display_currency_code,
    	timezone,
    	weight_unit,
    	base_url,
    	base_link_url,
    	base_static_url,
    	base_media_url,
    	secure_base_url,
    	secure_base_link_url,
    	secure_base_static_url,
    	secure_base_media_url 
  }
}

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jul 18, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@nuzil nuzil self-assigned this Jul 19, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jul 20, 2018
@nuzil
Copy link
Contributor

nuzil commented Jul 20, 2018

Looks great! I will made some additional checks and if everything fine we can merge it

@nuzil nuzil mentioned this pull request Jul 20, 2018
Closed
nuzil
nuzil suggested changes Jul 20, 2018
View reviewed changes
dev/tests/api-functional/testsuite/Magento/GraphQl/Store/StoreConfigResolverTest.php Outdated
= <<<QUERY
{
storeConfig{
items{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please align test. Looks like you removed "items" on your last code update. Should be also removed here.

@VitaliyBoyko VitaliyBoyko requested a review from nuzil July 23, 2018 09:14
@sidolov sidolov mentioned this pull request Jul 24, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit 8f3c6e9 into magento:2.3-develop Jul 24, 2018
magento-engcom-team pushed a commit that referenced this pull request Jul 24, 2018
ENGCOM-2445: 120 implement store configs coverage #126
d4e6297
@zetlen zetlen mentioned this pull request Jul 30, 2018
Closed
@keharper keharper mentioned this pull request Sep 6, 2018
Merged
4 tasks
magento-engcom-team pushed a commit that referenced this pull request May 31, 2019
@tomreece
Merge pull request #126 from magento-pangolin/MC-4558
3e224f0 
MC-4558
@revanth0212 revanth0212 mentioned this pull request Sep 10, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nuzil nuzil nuzil approved these changes

Assignees

@naydav naydav

@nuzil nuzil

Labels
2.3-develop Award: test coverage documentation-completed Imported Partner: Atwix partners-contribution pwa-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@VitaliyBoyko @magento-cicd2 @nuzil @naydav @keharper @magento-engcom-team