Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

Include storeName in storeConfig. #926

Closed
revanth0212 opened this issue Sep 10, 2019 · 0 comments
Closed

Include storeName in storeConfig. #926

revanth0212 opened this issue Sep 10, 2019 · 0 comments
Assignees
@pmclain
Labels
documentation-completed
Milestone
Release: 2.3.4

Comments

@revanth0212
Copy link

revanth0212 commented Sep 10, 2019 •
edited
Loading

Description

Store Config as of today has all the information regarding the Current Store. This was implemented as part of #126.

We also need storeName as part of storeConfig. This will unblock magento/pwa-studio#1617.

Expected behavior

storeConfig should have storeName.

Benefits

Venia can fetch storeName at compile-time and insert that into the build.

Additional information

NA
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pmclain pmclain

Labels
documentation-completed
Projects
None yet
Milestone
Release: 2.3.4
Development

No branches or pull requests
4 participants
@keharper @pmclain @lenaorobei @revanth0212