MAGECLOUD-1162: [GitHub] Deleting var/log while still writing to var/log/cloud.log

src/Process/Build/BackupData.php

@@ -5,6 +5,7 @@
  */
 namespace Magento\MagentoCloud\Process\Build;
 
+use Magento\MagentoCloud\App\Logger\Pool as LoggerPool;
 use Magento\MagentoCloud\Config\Environment;
 use Magento\MagentoCloud\Filesystem\DirectoryList;
 use Magento\MagentoCloud\Filesystem\Driver\File;
@@ -40,22 +41,30 @@ class BackupData implements ProcessInterface
      */
     private $directoryList;
 
+    /**
+     * @var LoggerPool
+     */
+    private $loggerPool;
+
     /**
      * @param File $file
      * @param LoggerInterface $logger
      * @param Environment $environment
      * @param DirectoryList $directoryList
+     * @param LoggerPool $loggerPool
      */
     public function __construct(
         File $file,
         LoggerInterface $logger,
         Environment $environment,
-        DirectoryList $directoryList
+        DirectoryList $directoryList,
+        LoggerPool $loggerPool
     ) {
         $this->file = $file;
         $this->logger = $logger;
         $this->environment = $environment;
         $this->directoryList = $directoryList;
+        $this->loggerPool = $loggerPool;
     }
 
     /**
@@ -96,6 +105,8 @@ public function execute()
 
         $this->logger->info('Copying writable directories to temp directory.');
 
+        $this->stopLogging();
+
         foreach ($this->environment->getWritableDirectories() as $dir) {
             $originalDir = $magentoRoot . $dir;
             $initDir = $rootInitDir . $dir;
@@ -109,5 +120,26 @@ public function execute()
                 $this->file->createDirectory($originalDir);
             }
         }
+
+        $this->restoreLogging();
+    }
+
+    /**
+     * Removes all log handlers for closing all connections to files that are opened for logging.
+     *
+     * It's done for avoiding file system exceptions while file opened for writing is not physically exists
+     * and some process trying to write into that file.
+     */
+    private function stopLogging()
+    {
+        $this->logger->setHandlers([]);
+    }
+
+    /**
+     * Restore all log handlers.
+     */
+    private function restoreLogging()
+    {
+        $this->logger->setHandlers($this->loggerPool->getHandlers());
     }
 }

src/Test/Unit/Process/Build/BackupDataTest.php

@@ -5,6 +5,7 @@
  */
 namespace Magento\MagentoCloud\Test\Unit\Process\Build;
 
+use Magento\MagentoCloud\App\Logger\Pool as LoggerPool;
 use Magento\MagentoCloud\Config\Environment;
 use Magento\MagentoCloud\Filesystem\DirectoryList;
 use Magento\MagentoCloud\Filesystem\Driver\File;
@@ -42,6 +43,11 @@ class BackupDataTest extends TestCase
      */
     private $directoryListMock;
 
+    /**
+     * @var LoggerPool|\PHPUnit_Framework_MockObject_MockObject
+     */
+    private $loggerPoolMock;
+
     /**
      * @inheritdoc
      */
@@ -51,13 +57,15 @@ protected function setUp()
             ->disableOriginalConstructor()
             ->getMock();
         $this->loggerMock = $this->getMockBuilder(LoggerInterface::class)
+            ->setMethods(['setHandlers', 'info'])
             ->getMockForAbstractClass();
         $this->environmentMock = $this->getMockBuilder(Environment::class)
             ->disableOriginalConstructor()
             ->getMock();
         $this->directoryListMock = $this->getMockBuilder(DirectoryList::class)
             ->disableOriginalConstructor()
             ->getMock();
+        $this->loggerPoolMock = $this->createMock(LoggerPool::class);
 
         $this->directoryListMock->expects($this->once())
             ->method('getMagentoRoot')
@@ -66,11 +74,22 @@ protected function setUp()
             ->method('getInit')
             ->willReturn('magento_root/init');
 
+        $this->loggerPoolMock->expects($this->once())
+            ->method('getHandlers')
+            ->willReturn(['handler1', 'handler2']);
+        $this->loggerMock->expects($this->exactly(2))
+            ->method('setHandlers')
+            ->withConsecutive(
+                [[]],
+                [['handler1', 'handler2']]
+            );
+
         $this->process = new BackupData(
             $this->fileMock,
             $this->loggerMock,
             $this->environmentMock,
-            $this->directoryListMock
+            $this->directoryListMock,
+            $this->loggerPoolMock
         );
     }