MAGECLOUD-1162: [GitHub] Deleting var/log while still writing to var/log/cloud.log #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During the build phase of m2-ece-build, one of the build processes attempts to delete the var/log dir while another process still has var/log/cloud.log open for writing.
On an NFS system, this will cause an .nfsXXX file to be created when cloud.log is unlinked from one process while the other is still running. Consequently, a file system exception is thrown, and m2-ece-build is aborted.
While this may not be an issue in the Platform.sh containers, it is an error in the logic (to have one process delete a file that another is actively writing to), and we have to modify the code to use it locally.
Fixed Issues (if relevant)
https://magento2.atlassian.net/browse/MAGECLOUD-1162
Zephyr Tests
Contribution checklist