Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAGECLOUD-1162: [GitHub] Deleting var/log while still writing to var/log/cloud.log #113

Merged
merged 3 commits into from
Dec 11, 2017
Merged

MAGECLOUD-1162: [GitHub] Deleting var/log while still writing to var/log/cloud.log #113

merged 3 commits into from
Dec 11, 2017

Conversation

oshmyheliuk
Copy link
Contributor

Description

During the build phase of m2-ece-build, one of the build processes attempts to delete the var/log dir while another process still has var/log/cloud.log open for writing.
On an NFS system, this will cause an .nfsXXX file to be created when cloud.log is unlinked from one process while the other is still running. Consequently, a file system exception is thrown, and m2-ece-build is aborted.
While this may not be an issue in the Platform.sh containers, it is an error in the logic (to have one process delete a file that another is actively writing to), and we have to modify the code to use it locally.

Fixed Issues (if relevant)

https://magento2.atlassian.net/browse/MAGECLOUD-1162

Zephyr Tests

  1. Run build and deploy scripts from ece-tools on NFS file system.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • Pull request was approved by architect
  • Pull request was approved by QA member
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@shiftedreality shiftedreality changed the title MAGECLOUD-1162 [GitHub] Deleting var/log while still writing to var/log/cloud.log MAGECLOUD-1162: [GitHub] Deleting var/log while still writing to var/log/cloud.log Dec 10, 2017
@andriyShevtsov
Copy link
Contributor

QA approved

@andriyShevtsov andriyShevtsov self-requested a review December 11, 2017 09:19
@shiftedreality shiftedreality added Progress: accept PR/issue status and removed Progress: testing in progress PR/issue status labels Dec 11, 2017
@shiftedreality shiftedreality merged commit d613e20 into magento:develop Dec 11, 2017
@shiftedreality shiftedreality deleted the MAGECLOUD-1162 branch December 11, 2017 09:19
magento-devops-reposync-svc pushed a commit that referenced this pull request Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Progress: accept PR/issue status Release: 2002.0.8 ECE-Tools Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants