Swap reflection probe cull mask and reflection mask #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Bastiaan Olij <[email protected]>
m4rr5
force-pushed
the
add_reflection_mask
branch
from
133122e to
b50709f
Compare
m4rr5
pushed a commit
that referenced
this pull request
Jan 18, 2024
The following formats are now accepted (leading `#` is optional): - `#1` -> `#111111` - `godotengine#12` -> `#121212` - `godotengine#12345` -> `#11223344` (`5` at the end is discarded) - `#1234567` -> `#123456` (`7` at the end is discarded)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Marrs,
If you merge this into your branch, it will swap the reflection mask and cull mask. See the discussion in your PR.
You'll have to squash the commits afterwards.