Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor: add checkbox to monitor list #12345

Merged
merged 1 commit into from Oct 23, 2017
Merged

Monitor: add checkbox to monitor list #12345

merged 1 commit into from Oct 23, 2017

Conversation

ghost
Copy link

@ghost ghost commented Oct 23, 2017

so that users don't have to hold CTRL to select multiple entries, and it's more obvious what to do to show the graph.

Merge after #12343 as there might be some conflicts, but changes are compatible.

image

@ghost ghost added this to the 3.0 milestone Oct 23, 2017
@ghost ghost added the usability label Oct 23, 2017
@karroffel
Copy link
Contributor

This has a nice PR number.

@akien-mga
Copy link
Member

Conflicts indeed.

@akien-mga akien-mga closed this Oct 23, 2017
@akien-mga
Copy link
Member

Oops

@akien-mga akien-mga reopened this Oct 23, 2017
so that users don't have to hold CTRL to select multiple entries.
@ghost
Copy link
Author

ghost commented Oct 23, 2017

Conflict resolved

@akien-mga akien-mga merged commit 832a536 into godotengine:master Oct 23, 2017
@ghost ghost deleted the perf branch October 23, 2017 18:49
Calinou added a commit to Calinou/godot that referenced this pull request Jan 8, 2024
The following formats are now accepted (leading `#` is optional):

- `#1` -> `#111111`
- `godotengine#12` -> `#121212`
- `godotengine#12345` -> `#11223344` (`5` at the end is discarded)
- `#1234567` -> `#123456` (`7` at the end is discarded)
GuybrushThreepwood-GitHub pushed a commit to GuybrushThreepwood-GitHub/godot that referenced this pull request Jan 27, 2024
The following formats are now accepted (leading `#` is optional):

- `godotengine#1` -> `#111111`
- `godotengine#12` -> `#121212`
- `godotengine#12345` -> `#11223344` (`5` at the end is discarded)
- `#1234567` -> `#123456` (`7` at the end is discarded)
Akshajk3 added a commit to Akshajk3/godot that referenced this pull request Dec 14, 2024
…dotengine#12345\)

- Modified the `RayCast3D.get_collider()` function to ensure it only returns `CollisionObject3D` instances.
- The function now uses `Object::cast_to<CollisionObject3D>(object)` to perform a safe cast and return null if the object is not of the expected type.
- This resolves issues where `RayCast3D.get_collider()` could return objects like `CSGShape3D`, leading to runtime errors and incorrect behavior.

Fixes: godotengine#12345
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants