[documentation] Document prom-remote backend type #3777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Antanukas Pretty good so far, just small grammar nits and tweaks. |
Co-authored-by: Chris Chinchilla <[email protected]>
Signed-off-by: ChrisChinchilla <[email protected]>
…oth expandable and leaf path values (#3784)
Passing the interrupt channel to multiple goroutines could cause a race where the main thread ends up missing the interrupt that triggers a server shutdown. This commit ensures that only a single goroutine is listening for the interrupt at a given time and all other interested parties can check the interrupted channel. The interrupted channel will be closed as soon as an interrupt is received. Since closed channels return immediately, this allows any interested goroutine to know if it should terminate by simply checking the interrupted channel.
This commit fixes a couple small things re: embedded coordinators: 1) Fails fast if dbnode is not started when creating an embedded coordinator. 2) Adds support for port and filepath replacement in embedded config.
…ss Coordinator (#3786) This PR adds some admin functions to the in-process coordinators, so they can manage m3msg topics and aggregator placements. In-process aggregators will be implemented based on this change. Co-authored-by: Wesley Kim <[email protected]>
Antanukas
requested review from
linasm,
vpranckaitis,
soundvibe,
robskillington and
benraskin92
robskillington
approved these changes
Oct 6, 2021
Codecov Report
@@ Coverage Diff @@
## master #3777 +/- ##
======================================
Coverage 57.0% 57.0%
======================================
Files 552 552
Lines 63120 63120
======================================
Hits 36023 36023
Misses 23902 23902
Partials 3195 3195
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
vpranckaitis
approved these changes
Oct 7, 2021
site/content/includes/integrations/prometheus/prometheus-scraper.yml
Outdated
Show resolved
Hide resolved
…er.yml Co-authored-by: Vilius Pranckaitis <[email protected]>
Co-authored-by: Vilius Pranckaitis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Documentation of a new backend type
prom-remoteSpecial notes for your reviewer:
The idea was to give a very concrete examples on how to run M3 Coordinator with
prom-remotestorage localy.I also describe 2 production deployment scenarios:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: