[tests] Improved embedded coordinator support #3779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jaredjenkins PR addresses this comment: #3759 (comment) |
nbroyles
force-pushed
the
nb/girl-interrupted
branch
from
63fde68 to
c5e959a
Compare
nbroyles
force-pushed
the
nb/dbnode-started
branch
2 times, most recently
from
b9d3f00 to
7632e3a
Compare
Codecov Report
@@ Coverage Diff @@
## master #3779 +/- ##
========================================
Coverage ? 56.8%
========================================
Files ? 552
Lines ? 62992
Branches ? 0
========================================
Hits ? 35832
Misses ? 23964
Partials ? 3196
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
| @@ -248,6 +254,12 @@ func (c *coordinator) WaitForShardsReady() error { | |||
| } | |||
|
|
|||
| func (c *coordinator) Close() error { | |||
| if c.embedded { | |||
There was a problem hiding this comment.
Would be nice if this just handled double closes sanely regardless of embedded or not.
jaredjenkins
approved these changes
Sep 28, 2021
nbroyles
force-pushed
the
nb/girl-interrupted
branch
from
c5e959a to
aad6cfd
Compare
Passing the interrupt channel to multiple goroutines could cause a race where the main thread ends up missing the interrupt that triggers a server shutdown. This commit ensures that only a single goroutine is listening for the interrupt at a given time and all other interested parties can check the interrupted channel. The interrupted channel will be closed as soon as an interrupt is received. Since closed channels return immediately, this allows any interested goroutine to know if it should terminate by simply checking the interrupted channel.
nbroyles
force-pushed
the
nb/girl-interrupted
branch
from
aad6cfd to
91a7015
Compare
This commit fixes a couple small things re: embedded coordinators: 1) Fails fast if dbnode is not started when creating an embedded coordinator. 2) Adds support for port and filepath replacement in embedded config.
nbroyles
force-pushed
the
nb/dbnode-started
branch
from
7632e3a to
a0958f2
Compare
Antanukas
pushed a commit
that referenced
this pull request
Oct 5, 2021
This commit fixes a couple small things re: embedded coordinators: 1) Fails fast if dbnode is not started when creating an embedded coordinator. 2) Adds support for port and filepath replacement in embedded config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This commit fixes a couple small things re: embedded coordinators:
Fails fast if dbnode is not started when creating an embedded
coordinator.
Adds support for port and filepath replacement in embedded
config.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: