Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dbnode] Add back teardown of containers at end of Prometheus integration test #3349

Merged

Conversation

robskillington
Copy link
Collaborator

What this PR does / why we need it:

Accidentally removed the defer.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

@robskillington robskillington enabled auto-merge (squash) March 11, 2021 20:05
@robskillington robskillington merged commit 49f8c14 into master Mar 11, 2021
@robskillington robskillington deleted the r/restore-stop-prometheus-integration-test-containers branch March 11, 2021 20:14
soundvibe added a commit that referenced this pull request Mar 15, 2021
* master:
  [dbnode] Remove unused getMockReader (#3351)
  [dbnode] Add back teardown of containers at end of Prometheus integration test (#3349)
  [query] Add series metadata label limit header for trimming response (#3348)

# Conflicts:
#	src/dbnode/storage/shard_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants