[query] Add series metadata label limit header for trimming response #3348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleyk
reviewed
Mar 11, 2021
| TotalSeries: returnedDataLimited.TotalSeries, | ||
| Datapoints: returnedDataLimited.Datapoints, | ||
| } | ||
| err = handleroptions.AddResponseHeaders(w, resultMetadata, fetchOptions, limited, nil) |
There was a problem hiding this comment.
so we're always adding the response header now, 👍
cc @rallen090
rallen090
reviewed
Mar 11, 2021
| ReturnedSeriesMetadataLimit: opts.ReturnedSeriesMetadataLimit, | ||
| } | ||
| ) | ||
| renderResult, err := prometheus.RenderSeriesMatchResultsJSON(noopWriter, results, renderOpts) |
There was a problem hiding this comment.
Can we leave comments on these noop render calls to explain the purpose is to apply the limiting first so we can write the header before the actual body writing?
rallen090
reviewed
Mar 11, 2021
| total += len(tag.Values) | ||
| if opts.ReturnedSeriesMetadataLimit > 0 && rendered >= opts.ReturnedSeriesMetadataLimit { | ||
| limited = true | ||
| continue |
There was a problem hiding this comment.
Ok I see - so we continue here so we can still count total
robskillington
deleted the
r/add-series-metadata-label-limit-header-response
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds ability to trim series metadata / label metadata via header.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: