-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Honor namespace-level "WritesToCommitlog" configuration #1232
Conversation
…sts for WriteBatch and WriteTaggedBatch
Codecov Report
@@ Coverage Diff @@
## master #1232 +/- ##
========================================
- Coverage 70.8% 70.7% -0.1%
========================================
Files 746 746
Lines 62952 62958 +6
========================================
- Hits 44582 44566 -16
- Misses 15503 15517 +14
- Partials 2867 2875 +8
Continue to review full report at Codecov.
|
3 similar comments
Codecov Report
@@ Coverage Diff @@
## master #1232 +/- ##
========================================
- Coverage 70.8% 70.7% -0.1%
========================================
Files 746 746
Lines 62952 62958 +6
========================================
- Hits 44582 44566 -16
- Misses 15503 15517 +14
- Partials 2867 2875 +8
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1232 +/- ##
========================================
- Coverage 70.8% 70.7% -0.1%
========================================
Files 746 746
Lines 62952 62958 +6
========================================
- Hits 44582 44566 -16
- Misses 15503 15517 +14
- Partials 2867 2875 +8
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1232 +/- ##
========================================
- Coverage 70.8% 70.7% -0.1%
========================================
Files 746 746
Lines 62952 62958 +6
========================================
- Hits 44582 44566 -16
- Misses 15503 15517 +14
- Partials 2867 2875 +8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes a bug introduced in #1157 where we ignore the WritesToCommitlog flag on the namespace configuration