Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor namespace-level "WritesToCommitlog" configuration #1232

Merged
merged 4 commits into from
Dec 6, 2018

Conversation

richardartoul
Copy link
Contributor

@richardartoul richardartoul commented Dec 6, 2018

Fixes a bug introduced in #1157 where we ignore the WritesToCommitlog flag on the namespace configuration

@codecov
Copy link

codecov bot commented Dec 6, 2018

Codecov Report

Merging #1232 into master will decrease coverage by <.1%.
The diff coverage is 66.6%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1232     +/-   ##
========================================
- Coverage    70.8%   70.7%   -0.1%     
========================================
  Files         746     746             
  Lines       62952   62958      +6     
========================================
- Hits        44582   44566     -16     
- Misses      15503   15517     +14     
- Partials     2867    2875      +8
Flag Coverage Δ
#aggregator 81.6% <ø> (ø) ⬆️
#cluster 85.7% <ø> (-0.1%) ⬇️
#collector 78.4% <ø> (ø) ⬆️
#dbnode 80.8% <66.6%> (-0.1%) ⬇️
#m3em 73.2% <ø> (ø) ⬆️
#m3ninx 75.2% <ø> (-0.1%) ⬇️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 18.2% <ø> (ø) ⬆️
#msg 74.9% <ø> (ø) ⬆️
#query 60.3% <ø> (ø) ⬆️
#x 74.4% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90f21b2...0e577db. Read the comment docs.

3 similar comments
@codecov
Copy link

codecov bot commented Dec 6, 2018

Codecov Report

Merging #1232 into master will decrease coverage by <.1%.
The diff coverage is 66.6%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1232     +/-   ##
========================================
- Coverage    70.8%   70.7%   -0.1%     
========================================
  Files         746     746             
  Lines       62952   62958      +6     
========================================
- Hits        44582   44566     -16     
- Misses      15503   15517     +14     
- Partials     2867    2875      +8
Flag Coverage Δ
#aggregator 81.6% <ø> (ø) ⬆️
#cluster 85.7% <ø> (-0.1%) ⬇️
#collector 78.4% <ø> (ø) ⬆️
#dbnode 80.8% <66.6%> (-0.1%) ⬇️
#m3em 73.2% <ø> (ø) ⬆️
#m3ninx 75.2% <ø> (-0.1%) ⬇️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 18.2% <ø> (ø) ⬆️
#msg 74.9% <ø> (ø) ⬆️
#query 60.3% <ø> (ø) ⬆️
#x 74.4% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90f21b2...0e577db. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 6, 2018

Codecov Report

Merging #1232 into master will decrease coverage by <.1%.
The diff coverage is 66.6%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1232     +/-   ##
========================================
- Coverage    70.8%   70.7%   -0.1%     
========================================
  Files         746     746             
  Lines       62952   62958      +6     
========================================
- Hits        44582   44566     -16     
- Misses      15503   15517     +14     
- Partials     2867    2875      +8
Flag Coverage Δ
#aggregator 81.6% <ø> (ø) ⬆️
#cluster 85.7% <ø> (-0.1%) ⬇️
#collector 78.4% <ø> (ø) ⬆️
#dbnode 80.8% <66.6%> (-0.1%) ⬇️
#m3em 73.2% <ø> (ø) ⬆️
#m3ninx 75.2% <ø> (-0.1%) ⬇️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 18.2% <ø> (ø) ⬆️
#msg 74.9% <ø> (ø) ⬆️
#query 60.3% <ø> (ø) ⬆️
#x 74.4% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90f21b2...0e577db. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 6, 2018

Codecov Report

Merging #1232 into master will decrease coverage by <.1%.
The diff coverage is 66.6%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1232     +/-   ##
========================================
- Coverage    70.8%   70.7%   -0.1%     
========================================
  Files         746     746             
  Lines       62952   62958      +6     
========================================
- Hits        44582   44566     -16     
- Misses      15503   15517     +14     
- Partials     2867    2875      +8
Flag Coverage Δ
#aggregator 81.6% <ø> (ø) ⬆️
#cluster 85.7% <ø> (-0.1%) ⬇️
#collector 78.4% <ø> (ø) ⬆️
#dbnode 80.8% <66.6%> (-0.1%) ⬇️
#m3em 73.2% <ø> (ø) ⬆️
#m3ninx 75.2% <ø> (-0.1%) ⬇️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 18.2% <ø> (ø) ⬆️
#msg 74.9% <ø> (ø) ⬆️
#query 60.3% <ø> (ø) ⬆️
#x 74.4% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90f21b2...0e577db. Read the comment docs.

Copy link
Collaborator

@justinjc justinjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardartoul richardartoul merged commit 458cf4a into master Dec 6, 2018
@justinjc justinjc deleted the ra/fix-writes-to-commitlog branch January 7, 2019 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants