Implement the ability to write in batches in M3DB database #1157
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1157 +/- ##
========================================
- Coverage 71.5% 71.5% -0.1%
========================================
Files 726 728 +2
Lines 60839 61085 +246
========================================
+ Hits 43540 43683 +143
- Misses 14523 14602 +79
- Partials 2776 2800 +24
Continue to review full report at Codecov.
|
richardartoul
changed the title
| @@ -45,17 +45,25 @@ var ( | |||
| timeZero = time.Time{} | |||
| ) | |||
|
|
|||
| // WritesBatch is a batch of Write. | |||
| type WritesBatch []Write | |||
There was a problem hiding this comment.
Can we wrap this up in a struct (which we could then later pool)?
There was a problem hiding this comment.
Can we also rename it to WriteBatch and drop the s? Just since in other places where we have write batches that's what we call them.
| Tags ident.Tags // FOLLOWUP(prateek): wire Tags to commit log writer | ||
| Tags ident.Tags | ||
|
|
||
| TagIter ident.TagIterator |
There was a problem hiding this comment.
Just curious, why do we have both now? Is it an either/or argument?
There was a problem hiding this comment.
Its an either/or kind of thing. It kind of sucks but you have to turn this into a partially filled struct thing so you don't have ot convert one massive slice of one thing into another massive slice of another thing. I'll do some cleanup, add some comments, and try to see if i can explain / document this in a sane manner
There was a problem hiding this comment.
Can we create a wrapper type TagsOrTagsIter struct and perhaps a type TagsType uint enum like to specify which one to use?
richardartoul
force-pushed
the
ra/batches
branch
from
0190262 to
b647dc0
Compare
No description provided.