Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(src): enable types as peer dependencies to get around bumping wi… #35

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
@@ -45,12 +45,15 @@
"sinon": "^11.1.1",
"tslib": "^2.1.0"
},
"peerDependencies": {
"@aws-sdk/types": "^3.0.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should allow any aws-sdk/type above 3.0.0 that the customer wants to bring. This is should be resolved at a higher tree node when people npm install

},
"devDependencies": {
"@aws-sdk/client-dynamodb": "3.18.0",
"@aws-sdk/client-sns": "3.18.0",
"@aws-sdk/client-sqs": "3.18.0",
"@aws-sdk/lib-dynamodb": "3.18.0",
"@aws-sdk/types": "3.18.0",
"@aws-sdk/types": "^3.18.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Types is also the latest for just dev work.

"@aws-sdk/client-dynamodb": "^3.18.0",
"@aws-sdk/client-sns": "^3.18.0",
"@aws-sdk/client-sqs": "^3.18.0",
"@aws-sdk/lib-dynamodb": "^3.18.0",
Comment on lines +52 to +56
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the latest versions updated for local tests. We may as well just pull in the latest for tests to run against those.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep in mind that the ^ doesn't mean the "latest" will be installed when you run npm / yarn install. If you install dependencies today and a new version will be released tomorrow, running yarn install again will not install the fresh versions, since the matching ones are already installed.

This is one of the reasons why I prefer to specify exact dependency versions (in open source only dev dependencies ofc).

But let's keep it that way, I may just change it later.

"@commitlint/cli": "11.0.0",
"@commitlint/config-conventional": "11.0.0",
"@size-limit/preset-small-lib": "4.10.2",
1,896 changes: 852 additions & 1,044 deletions yarn.lock

Large diffs are not rendered by default.