feat(src): enable types as peer dependencies to get around bumping wi… #35
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,12 +45,15 @@ | |
| "sinon": "^11.1.1", | ||
| "tslib": "^2.1.0" | ||
| }, | ||
| "peerDependencies": { | ||
| "@aws-sdk/types": "^3.0.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@aws-sdk/types": "^3.18.0", | ||
|
There was a problem hiding this comment. Types is also the latest for just dev work. |
||
| "@aws-sdk/client-dynamodb": "^3.18.0", | ||
| "@aws-sdk/client-sns": "^3.18.0", | ||
| "@aws-sdk/client-sqs": "^3.18.0", | ||
| "@aws-sdk/lib-dynamodb": "^3.18.0", | ||
|
Comment on lines
+52
to
+56
There was a problem hiding this comment. Keep the latest versions updated for local tests. We may as well just pull in the latest for tests to run against those. There was a problem hiding this comment. Keep in mind that the This is one of the reasons why I prefer to specify exact dependency versions (in open source only dev dependencies ofc). But let's keep it that way, I may just change it later. |
||
| "@commitlint/cli": "11.0.0", | ||
| "@commitlint/config-conventional": "11.0.0", | ||
| "@size-limit/preset-small-lib": "4.10.2", | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should allow any aws-sdk/type above 3.0.0 that the customer wants to bring. This is should be resolved at a higher tree node when people
npm install