Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better implementation to test if connection to db is active #843

Conversation

richardxia
Copy link

Hi @cbliard and @booleanbetrayal, I hope you don't mind me submitting a pull request for a commit that you added, @cbliard. I was running into the same issue as #814, and in fact am running into the problem described in #814 (comment) regarding Postgres. I'd greatly appreciate it if we could merge this into master so that I don't have to set up a real Postgres database in my Docker image building environment, which is the only way I can currently work around the issue.

emcgee added a commit to ringplus/devise_token_auth that referenced this pull request Jul 5, 2017
@emcgee
Copy link

emcgee commented Jul 5, 2017

Quick 👍 bump. Any chance this could get merged?

@booleanbetrayal
Copy link
Collaborator

Thanks @richardxia

@booleanbetrayal booleanbetrayal merged commit c158898 into lynndylanhurley:master Jul 6, 2017
@AbdullahAli
Copy link

Can you please make a release for this? The latest release is back in May and does not include this change

@zachfeldman
Copy link
Contributor

@lynndylanhurley is working on it

@chandranshu12
Copy link

Our team has been running into this issue for a while now with MySql. Basically the ActiveRecord::NoDatabaseError in case of MySql is only raised if the user is authorized to connect but the db is not found. On the build server where the Docker image is built, there is no mysql server to even connect to and the exception raised is an instance of MySql2::Error which is of course not handled in the current version. This merge request handles that as well. Please merge.

@zachfeldman
Copy link
Contributor

Hey @chandranshu12 this has been merged. You can use the master branch instead of what's on Rubygems if you'd like

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants