Prevent getting table info if not connected to db #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is failing on Travis @cbliard . Will need you to take a look before I can merge. |
Fixes lynndylanhurley#327 When precompiling assets while building a docker image, the database is not available and the DeviseTokenAuth::Concerns::User concern tries to load user table information from database and fails. It now checks if the database connection is available before gathering information about user table.
cbliard
force-pushed
the
fix-327-concern-cause-app-to-connect-to-db
branch
from
6d9ee77 to
6d764da
Compare
|
@booleanbetrayal Sorry, I did not notice. I just fixed it. |
|
thanks @cbliard ! |
|
In fact, this implementation is far from ideal. It fails to catch connection errors with PostgreSQL which raises Should I open a new pull request or is it possible to change this one? |
|
@cbliard - this has already been merged. Please just open a new PR and ping me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #327
When precompiling assets while building a docker image, the database is not
available and the DeviseTokenAuth::Concerns::User concern tries to load
user table information from database and fails. It now checks if the
database connection is established before gathering information about user
table.