-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
devise_token_auth blocks upgrade to Rails 5.1.0 #875
Comments
Looks like this is the issue heartcombo/devise#4510 This library will need to be updated to depend on a newer version of devise once they release an upstream fix. |
Hi Team! Still no solution yet? I'm trying on MacOS but still getting the error:
Have tried everything in SO, but no success... |
@heptaman the Devise team haven't cut a new release or pushed to ruby gems yet to support Rails 5.1.0. Until that happens this gem cannot be updated to use the new Devise (I tried to get around it by forking this gem and updating the gemfile/gemspec to point to the Devise master branch, but this didn't work because bundler has safeguards designed to prevent gem authors from using git dependencies in production). |
This gem can already pre-emptively allow devise 4.3.0 in its gemspec to allow downstream users to use the master branches for both projects right now, and to use the new version of devise as soon as it's released. |
@christophermlne right now you can use this gem with Rails 5.1.0 by using this in your Gemfile:
|
@lynndylanhurley @christophermlne devise 4.3.0 has been released w/ support for rails 5.1 |
The solution above does not work anymore, as devise 4.2.1 does not support railties 5.1.0 and devise_token_auth does not yet support devise 4.3.0 that supports railties 5.1.0. |
@romdim do you mean my solution in #875 (comment)? That should still work. What output do you get? |
You're right @mvz, my bad, I didn't take it by reference, used the master branch instead. |
Definitely! |
Closed via #891 -- Will try to cut builds shortly |
Just pushed v0.1.42 |
The text was updated successfully, but these errors were encountered: