Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devise_token_auth blocks upgrade to Rails 5.1.0 #875

Closed
christophermlne opened this issue Apr 28, 2017 · 12 comments
Closed

devise_token_auth blocks upgrade to Rails 5.1.0 #875

christophermlne opened this issue Apr 28, 2017 · 12 comments

Comments

@christophermlne
Copy link

$ bundle update                                                                        [2.2.3]
Fetching [email protected]:xxx/xxx.git
Fetching gem metadata from https://rubygems.org/.........
Fetching version metadata from https://rubygems.org/...
Fetching dependency metadata from https://rubygems.org/..
Resolving dependencies........................................................
Bundler could not find compatible versions for gem "railties":
  In Gemfile:
    devise_token_auth (= 0.1.40) was resolved to 0.1.40, which depends on
      devise (<= 4.2, > 3.5.2) was resolved to 3.5.3, which depends on
        railties (< 5, >= 3.2.6)
@christophermlne
Copy link
Author

christophermlne commented Apr 28, 2017

Looks like this is the issue heartcombo/devise#4510
And here is the PR for the release that will fix it heartcombo/devise#4512

This library will need to be updated to depend on a newer version of devise once they release an upstream fix.

@TheAdail
Copy link

TheAdail commented May 3, 2017

Hi Team! Still no solution yet? I'm trying on MacOS but still getting the error:

Bundler could not find compatible versions for gem "devise":
  In Gemfile:
    devise

    devise x64-mingw32

    devise_token_auth (~> 0.1.40) x64-mingw32 was resolved to 0.1.40, which depends on
      devise (<= 4.2, > 3.5.2)

    devise_token_auth (~> 0.1.40) x64-mingw32 was resolved to 0.1.40, which depends on
      devise (<= 4.2, > 3.5.2) x64-mingw32

Have tried everything in SO, but no success...

@christophermlne
Copy link
Author

christophermlne commented May 4, 2017

@heptaman the Devise team haven't cut a new release or pushed to ruby gems yet to support Rails 5.1.0. Until that happens this gem cannot be updated to use the new Devise (I tried to get around it by forking this gem and updating the gemfile/gemspec to point to the Devise master branch, but this didn't work because bundler has safeguards designed to prevent gem authors from using git dependencies in production).

@mvz
Copy link

mvz commented May 12, 2017

This gem can already pre-emptively allow devise 4.3.0 in its gemspec to allow downstream users to use the master branches for both projects right now, and to use the new version of devise as soon as it's released.

@mvz
Copy link

mvz commented May 12, 2017

@christophermlne right now you can use this gem with Rails 5.1.0 by using this in your Gemfile:

gem 'rails', '~> 5.1.0'
gem 'devise', git: 'https://github.com/plataformatec/devise.git', ref: 'a62faa2c8258ba1c35fe84e147f42c35eccccb8a'
gem 'devise_token_auth', git: 'https://github.com/lynndylanhurley/devise_token_auth.git'

@its-danny
Copy link

@lynndylanhurley @christophermlne devise 4.3.0 has been released w/ support for rails 5.1

@romdim
Copy link

romdim commented May 15, 2017

The solution above does not work anymore, as devise 4.2.1 does not support railties 5.1.0 and devise_token_auth does not yet support devise 4.3.0 that supports railties 5.1.0.
Please release or update master whenever possible. 4.3 does only that, updates the railties as I can see from https://github.com/plataformatec/devise/blob/master/CHANGELOG.md

@mvz
Copy link

mvz commented May 15, 2017

@romdim do you mean my solution in #875 (comment)? That should still work. What output do you get?

@romdim
Copy link

romdim commented May 15, 2017

You're right @mvz, my bad, I didn't take it by reference, used the master branch instead.
Still, a release would be preferable in order not to include git in docker's dependencies.

@mvz
Copy link

mvz commented May 15, 2017

Still, a release would be preferable

Definitely!

@booleanbetrayal
Copy link
Collaborator

Closed via #891 -- Will try to cut builds shortly

@booleanbetrayal
Copy link
Collaborator

Just pushed v0.1.42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants