Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 5.1 #4512

Merged
merged 2 commits into from
Apr 28, 2017
Merged

Rails 5.1 #4512

merged 2 commits into from
Apr 28, 2017

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Apr 28, 2017

Updated #4444 to use a final release of Rails 5.1

@jcoyne jcoyne mentioned this pull request Apr 28, 2017
@ghost
Copy link

ghost commented Apr 28, 2017

Any timeline on when this will be accepted?

@tomekr
Copy link

tomekr commented Apr 28, 2017

Hi, I did a clean install of Rails 5.1. with Devise and it looks like the responders gem is installing an old version as well. Gemfile.lock looks like:

GIT
  remote: https://github.com/jcoyne/devise.git
  revision: 7c4e8c8d17047bceea490173af42bfbbc54cf849
  branch: rails-5.1
  specs:
    devise (4.2.0)
      bcrypt (~> 3.0)
      orm_adapter (~> 0.1)
      railties (>= 4.1.0, < 5.2)
      responders
      warden (~> 1.2.3)
...
    responders (0.6.5)

The current version is 2.3.0. This then causes a mimes_for_respond_to error to occur when trying to request Devise endpoints.

@jcoyne
Copy link
Contributor Author

jcoyne commented Apr 28, 2017

@tomekr It's getting an old version because we're waiting on a release of the responders gem too. See heartcombo/responders#179

@lrosskamp
Copy link

lrosskamp commented Apr 28, 2017

my Gemfile.lock looks like this. I'm using Rails 5.1 and gem 'devise'
devise (1.5.4)
bcrypt-ruby (~> 3.0)
orm_adapter (~> 0.0.3)
warden (~> 1.1)

Any ideas?

@tomekr
Copy link

tomekr commented Apr 28, 2017

@jcoyne ahh good call, added gem "responders", git: 'https://github.com/plataformatec/responders.git', branch: 'master' for now and it looks like that fixed the issue.

@lrosskamp as a temporary solution until these PR's are merged I added the following to my Gemfile:

gem 'devise', git: 'https://github.com/jcoyne/devise.git', branch: 'rails-5.1'
gem "responders", git: 'https://github.com/plataformatec/responders.git', branch: 'master'

@davidmccoy
Copy link

Thanks @jcoyne!

@lrosskamp
Copy link

lrosskamp commented Apr 28, 2017

thanks @tomekr but I get this error:
https://github.com/plataformatec/responders.git (at master@153f2c6) is not yet checked out. Run `bundle install` first.

running bundle install doesn't fix it. Do you know what may have cause this?

@rafaelfranca rafaelfranca merged commit 4beeca4 into heartcombo:master Apr 28, 2017
@jcoyne jcoyne deleted the rails-5.1 branch April 28, 2017 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants