Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable standard tab detection for all JetBrains apps, not just EAPs #741

Closed
wants to merge 3 commits into from
Closed

Disable standard tab detection for all JetBrains apps, not just EAPs #741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f04b9b
fix: disable standard tab detection for all JetBrains apps
akx Dec 23, 2020
70a779e
chore(ci): don't use github token for public API
akx Dec 23, 2020
b33e6ed
chore(ci): ensure l10n projects exist
akx Dec 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scripts/import_l10n_strings_from_poeditor.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ function updateLanguageFile() {
-d order="terms" \
-d type="apple_strings")"
fileUrl="$(jq -r '.result.url' <<<"$exportApiJson")"
mkdir -p "resources/l10n/$1.lproj"
curl -s "$fileUrl" > "resources/l10n/$1.lproj/Localizable.strings"
}

Expand Down
1 change: 0 additions & 1 deletion scripts/update_contributors.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ projectId="316051"
echo -e "They helped [develop the app](https://github.com/lwouis/alt-tab-macos/graphs/contributors):\n"

curl https://api.github.com/repos/lwouis/alt-tab-macos/contributors \
-H "Authorization: token $GITHUB_TOKEN" |
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may seem like this is unnecessary, but I actually added this because from the CI machine (TravisCI), requests to github get quota'd and denied. Using a token means it doesn't fail because of that, as it deducted from that token's quota vs from the IP quota.

jq -r '.[]|("[" + .login + "](" + .html_url + ")")' |
sed -e '/semantic-release-bot/d' |
sort -f |
Expand Down
2 changes: 1 addition & 1 deletion src/logic/Application.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class Application: NSObject {
]
// workaround: some apps exhibit bugs when we subscribe to its kAXFocusedUIElementChangedNotification
// we don't know what's happening; we avoid this subscription to make these app usable
if app.bundleIdentifier == "edu.stanford.protege" || app.bundleIdentifier?.range(of: "^com\\.jetbrains\\..+?EAP$", options: .regularExpression) != nil {
if app.bundleIdentifier == "edu.stanford.protege" || app.bundleIdentifier?.range(of: "^com\\.jetbrains\\..+?$", options: .regularExpression) != nil {
return n.filter { $0 != kAXFocusedUIElementChangedNotification }
}
return n
Expand Down