Disable standard tab detection for all JetBrains apps, not just EAPs #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not just EAPs; those EAPs have been promoted into standard apps. Should fix lwouis#716
|
@lwouis Can I get a review for this? I think the CI fail is unrelated... |
|
@akx I'm sorry, I saw it during the holidays, and I'm trying to find time to review it. I'll try my best to work on it this week 👍 |
lwouis
reviewed
Jan 5, 2021
| @@ -11,7 +11,6 @@ projectId="316051" | |||
| echo -e "They helped [develop the app](https://github.com/lwouis/alt-tab-macos/graphs/contributors):\n" | |||
|
|
|||
| curl https://api.github.com/repos/lwouis/alt-tab-macos/contributors \ | |||
| -H "Authorization: token $GITHUB_TOKEN" | | |||
There was a problem hiding this comment.
It may seem like this is unnecessary, but I actually added this because from the CI machine (TravisCI), requests to github get quota'd and denied. Using a token means it doesn't fail because of that, as it deducted from that token's quota vs from the IP quota.
|
Thanks for the PR @akx! I'm going to cherry-pick the commits on the Closing this PR |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #716 (likely)