Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Window skipped after active active app becomes windowless #2065

Closed
probablykasper opened this issue Oct 31, 2022 · 2 comments
Closed

Window skipped after active active app becomes windowless #2065

probablykasper opened this issue Oct 31, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@probablykasper
Copy link

Describe the bug

When alt+tabbing after a window becomes windowless, the first item in the list is skipped over

Screenshots / video

Screen.Recording.2022-10-31.at.19.35.01.mp4

Video explanation:

  1. QuickTime Player is launched with no windows. Alt+tabbing correctly selects the 1st item
  2. A window is opened in QuickTime Player. Alt+tabbing correctly selects the 2nd item
  3. The window is closed, but QuickTime Player is still focused. Alt+tabbing incorrectly selects the 2nd item

Steps to reproduce the bug

  1. Open a file in QuickTime Player
  2. Close the window, but keep QuickTime Player in focus
  3. Alt+tab
@probablykasper probablykasper added the bug Something isn't working label Oct 31, 2022
@lwouis
Copy link
Owner

lwouis commented Oct 31, 2022

Thank you for sharing this issue @probablykasper!

I was able to reproduce the issue. I must say I was surprised because I remember taking care of this scenario a while ago (in f4d3db7). It turns out that I had only tested various other scenarios, but not that exact one. I added some logic to handle closed windows. It works correctly for me. Could you test this build?

Thank you

@probablykasper
Copy link
Author

Yep, the build works beautifully! :D

@lwouis lwouis closed this as completed in 281b3ed Nov 2, 2022
lwouis pushed a commit that referenced this issue Nov 2, 2022
@semantic-release-bot
chore(release): 6.49.0 [skip ci]
fe38b53 
# [6.49.0](v6.48.0...v6.49.0) (2022-11-02)

### Bug Fixes

* command+backtick not working if stage manager is on (closes [#2053](#2053)) ([848ae5f](848ae5f))
* crash when setting some shortcut combinations (closes [#2061](#2061)) ([8b2d659](8b2d659))
* hide minimize and fullscreen thumbnail buttons for tabs ([b62c422](b62c422))
* improve key repeat-rate when held (closes [#2026](#2026)) ([1821dea](1821dea))
* key-above-tab on international keyboards (closes [#1190](#1190)) ([4c31740](4c31740))
* thumbnails would sometimes be the wrong size ([1065c0d](1065c0d))
* wrong focus after active app becomes windowless (closes [#2065](#2065)) ([281b3ed](281b3ed))

### Features

* improve some localizations ([292e6b0](292e6b0))
* play alert sound for unavailable thumbnail shortcuts ([fd84a9a](fd84a9a))
* support adobe after effects non-standard windows (closes [#1982](#1982)) ([7b54873](7b54873))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lwouis @probablykasper