Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting command+option as a main shortcut crashes the app #2061

Closed
alt-tab-macos-bot opened this issue Oct 30, 2022 · 5 comments
Closed

Setting command+option as a main shortcut crashes the app #2061

alt-tab-macos-bot opened this issue Oct 30, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@alt-tab-macos-bot
Copy link

This issue was opened by a bot after a user submitted feedback through the in-app form.

From: [email protected]

Message:

Привет! Не работает переназначение клавиш в случае конфликта, программа вылетает. Я пытаюсь повесить переключение окон на Command + Option, но т.к. Option уже назначен на другом шорткате, приложение выводит предупреждение, после которого происходит вылет.

Debug profile

  • App version: 6.48.0
  • App preferences:
    • MSAppCenter310AppCenterUserDefaultsMigratedKey: 1
    • MSAppCenter310CrashesUserDefaultsMigratedKey: 1
    • MSAppCenterInstallId: 91C93945-92B3-4E71-9F72-D0FE839731CC
    • MSAppCenterNetworkRequestsAllowed: 0
    • MSAppCenterPastDevices: {length = 1150, bytes = 0x62706c69 73743030 d4010203 04050607 ... 00000000 0000038a }
    • MSAppCenterSessionIdHistory: {length = 460, bytes = 0x62706c69 73743030 d4010203 04050607 ... 00000000 00000156 }
    • MSAppCenterUserIdHistory: {length = 455, bytes = 0x62706c69 73743030 d4010203 04050607 ... 00000000 00000151 }
    • NSStatusItem Visible Item-0: 0
    • NSWindow Frame SUUpdateAlert: 310 282 660 398 0 0 1280 775
    • SUHasLaunchedBefore: 1
    • SULastCheckTime: 2022-10-26 11:52:07 +0000
    • SUSkippedVersion: 6.47.0
    • SUUpdateGroupIdentifier: 264892478
    • SUUpdateRelaunchingMarker: 0
    • alignThumbnails: 1
    • appsToShow: 0
    • crashPolicy: 2
    • fadeOutAnimation: false
    • fontHeight: 12
    • hideColoredCircles: true
    • hideSpaceNumberLabels: true
    • hideStatusIcons: false
    • hideThumbnails: false
    • hideWindowlessApps: false
    • holdShortcut: ⌥
    • holdShortcut2: ⌘
    • holdShortcut3: ⌘
    • holdShortcut4: ⌥
    • holdShortcut5: ⇧
    • iconSize: 28
    • maxHeightOnScreen: 100
    • maxWidthOnScreen: 100
    • menubarIcon: 3
    • nextWindowShortcut: ⇥
    • nextWindowShortcut2: ⌃
    • nextWindowShortcut3:
    • nextWindowShortcut5:
    • preferencesVersion: 6.48.0
    • previousWindowShortcut:
    • rowsCount: 4
    • screensToShow: 0
    • shortcutStyle: 0
    • shortcutStyle3: 1
    • shortcutStyle4: 1
    • shortcutStyle5: 1
    • showFullscreenWindows: 0
    • showMinimizedWindows: 0
    • showOnScreen: 0
    • showTabsAsWindows: false
    • spacesToShow: 0
    • spacesToShow4: 0
    • theme: 0
    • updatePolicy: 1
    • windowMaxWidthInRow: 30
    • windowMinWidthInRow: 15
  • Applications: 46
  • Windows: 7
    • {isFullscreen: false, isWindowlessApp: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceId: 2, spaceIndex: 1}
    • {isFullscreen: false, isWindowlessApp: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceId: 2, spaceIndex: 1}
    • {isFullscreen: false, isWindowlessApp: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceId: 2, spaceIndex: 1}
    • {isFullscreen: false, isWindowlessApp: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceId: 2, spaceIndex: 1}
    • {isFullscreen: false, isWindowlessApp: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceId: 2, spaceIndex: 1}
    • {isFullscreen: false, isWindowlessApp: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceId: 2, spaceIndex: 1}
    • {isFullscreen: false, isWindowlessApp: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceId: 2, spaceIndex: 1}
  • OS version: Версия 13.0 (Выпуск 22A380)
  • OS architecture: arm64
  • Locale: ru_RU (current)
  • Spaces: 4
  • Dark mode: Dark
  • "Displays have separate Spaces": checked
  • Hardware model: MacBookAir10,1
  • Screens: 1
    • {x: 0.0, y: 0.0, width: 1280.0, height: 800.0}
  • CPU model: Apple M1
  • Memory size: 8,59 ГБ
  • Active CPU count: 8
  • Current CPU frequency: nil
  • Resource utilization:
    • CPU: 0.2%
    • Memory: 65M
    • Threads count: 10

@dtovpik
Copy link

dtovpik commented Oct 30, 2022

Hi! The key assignment in case of conflict doesn't work, the application crashes. I'm trying to put window switching on Command + Option, but as Option is already assigned to another shortcut, the application displays a warning, after which it crashes.

@lwouis
Copy link
Owner

lwouis commented Oct 30, 2022

@dtovpik I was able to reproduce the issue by assigning Hold to command, and Select next window to option. This made me realize that the code to avoid shortcuts overlaping other shortcuts has lots of issue.

I'm glad you shared this issue. I'll rework the code and release a fix.

@lwouis lwouis changed the title [In-app feedback] Setting command+option as a main shortcut crashes the app Oct 30, 2022
@lwouis lwouis added the bug Something isn't working label Oct 30, 2022
@dtovpik
Copy link

dtovpik commented Oct 31, 2022

Thanks! And thank you for this wonderful application, it helps a lot to move between windows.

@lwouis
Copy link
Owner

lwouis commented Oct 31, 2022

Could you please tell me if this build fixes the issue for you?

@dtovpik
Copy link

dtovpik commented Oct 31, 2022

Thank you! This version does not have this bug, the keys are reassigned correctly:)

@lwouis lwouis closed this as completed in 8b2d659 Nov 2, 2022
lwouis pushed a commit that referenced this issue Nov 2, 2022
# [6.49.0](v6.48.0...v6.49.0) (2022-11-02)

### Bug Fixes

* command+backtick not working if stage manager is on (closes [#2053](#2053)) ([848ae5f](848ae5f))
* crash when setting some shortcut combinations (closes [#2061](#2061)) ([8b2d659](8b2d659))
* hide minimize and fullscreen thumbnail buttons for tabs ([b62c422](b62c422))
* improve key repeat-rate when held (closes [#2026](#2026)) ([1821dea](1821dea))
* key-above-tab on international keyboards (closes [#1190](#1190)) ([4c31740](4c31740))
* thumbnails would sometimes be the wrong size ([1065c0d](1065c0d))
* wrong focus after active app becomes windowless (closes [#2065](#2065)) ([281b3ed](281b3ed))

### Features

* improve some localizations ([292e6b0](292e6b0))
* play alert sound for unavailable thumbnail shortcuts ([fd84a9a](fd84a9a))
* support adobe after effects non-standard windows (closes [#1982](#1982)) ([7b54873](7b54873))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants