Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and consistently handle creation of tail continuations. #4

Merged
merged 1 commit into from
Oct 10, 2021
Merged

Fix and consistently handle creation of tail continuations. #4

merged 1 commit into from
Oct 10, 2021

Conversation

porcuquine
Copy link
Contributor

This builds on #3 in the way I think resolves all the issues.

  • When creating Tail continuations, we should reuse existing continuations as-is. The previous code was mistakenly using the 'parent'.
  • We should avoid recursion since the circuit can't handle it.
  • We should route all Tail-continuation-creation through make_tail_continuation to ensure its logic is enforced everywhere.

Happily, this also resolves all three (annoying) comments of the form FIXME: Reconcile with reference (extra tail thunk).

@porcuquine porcuquine requested a review from namin October 10, 2021 22:43
@namin
Copy link
Contributor

namin commented Oct 10, 2021

Thanks, preserving the invariant and not recursing makes so much sense.

@namin namin merged commit 52d24a3 into master Oct 10, 2021
@porcuquine porcuquine deleted the fix-tail-continuations branch October 11, 2021 00:25
huitseeker pushed a commit that referenced this pull request Jun 15, 2023
@johnchandlerburnham
WIP Jcb/refactor (#4)
9fff4dc 
* switch to nix flakes

* ldon and lurk_ff refactor, and lurk_core stub

* add flake

* reformatting

* remove Keyword expression

* rename ldon::ptr -> ldon::cid

* first draft of Store refactor
@huitseeker huitseeker mentioned this pull request Jun 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namin namin Awaiting requested review from namin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@porcuquine @namin