fix env lost when making tail call #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porcuquine
reviewed
Oct 10, 2021
| @@ -856,7 +856,7 @@ fn make_tail_continuation(env: &Expression, continuation: &Continuation) -> Cont | |||
| match &*continuation { | |||
| Continuation::Outermost => continuation.clone(), | |||
| // Match all tail continuations here. | |||
| Continuation::Tail(env, c) => *c.clone(), | |||
| Continuation::Tail(env, c) => make_tail_continuation(env, c), | |||
There was a problem hiding this comment.
Ah, good. However, we want to avoid a recursive call here since we need the circuit shape to be independent of input.
huitseeker
pushed a commit
that referenced
this pull request
Jun 15, 2023
* refactor Store -> ScalarStore conversion * ScalarStore conversion unit tests * tests passing * convert Tag::Nil to Tag::Sym on ScalarStore * fix tests for Tag::Nil change * fix Tag::from_field() * reversing bytes in 'display_string' * add ser_f de_f functions * implement syntax module * update Arbitrary impl for ScalarStore * add new lurk_ff crate for non-ipld LurkField trait * first draft of ldon crate * format files with new rustfmt * SerdeF serialization implemented and tested * first draft of ldon parser * parser now passing quickcheck * implement Syn::Link, fix Syn::Map ordering, fix nested Syn::List parsing * fixup warnings * update branch to PR * restore lurk-rs parent crate to master branch * fixes * fix CI * ldon macros * clippy for lurk_ff * ldon clippy * clarify README * add new tests and comments from demo * Apply suggestions from code review Co-authored-by: Samuel Burnham <[email protected]> * implement Cont serialization * update lurk_ff * update Cargo.lock Co-authored-by: Arthur Paulino <[email protected]> Co-authored-by: Samuel Burnham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.