Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rating frontend #101

Merged
merged 7 commits into from
Apr 8, 2021
Merged

Rating frontend #101

merged 7 commits into from
Apr 8, 2021

Conversation

lucashuy
Copy link
Owner

@lucashuy lucashuy commented Apr 7, 2021

@lucashuy
Copy link
Owner Author

lucashuy commented Apr 7, 2021

The profile component does not re-render after a URL change. Looking into fix

@lucashuy
Copy link
Owner Author

lucashuy commented Apr 8, 2021

Ready for review

humayraR
humayraR previously approved these changes Apr 8, 2021
Copy link
Collaborator

@humayraR humayraR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good other than the fact that i couldn't test adding/editing rating on a profile. Can be merged in case other branches need changes from this PR

Copy link
Collaborator

@humayraR humayraR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great and works as expected!

@lucashuy lucashuy merged commit 0763167 into master Apr 8, 2021
@lucashuy lucashuy deleted the rating_frontend branch April 16, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants