Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code smell regarding getUserIDFromToken() #78

Closed
lucashuy opened this issue Mar 20, 2021 · 0 comments · Fixed by #101
Closed

Code smell regarding getUserIDFromToken() #78

lucashuy opened this issue Mar 20, 2021 · 0 comments · Fixed by #101
Assignees
@lucashuy
Labels
bug
Milestone
Sprint 4

Comments

@lucashuy
Copy link
Owner

https://github.com/itslupus/gamersnet/blob/ece5e27df24e634c67815d434640d03b45153a44/gamersnet_backend/persistence/tokens.js#L52
Not quite a bug, more so a code smell. This function doesn't actually get the userID from token, it gets the entire token document. This should be fixed before Sprint 4 (though that probably falls into my hands since I wrote that function).
@lucashuy lucashuy added the bug label Mar 20, 2021
@lucashuy lucashuy added this to the Sprint 3 milestone Mar 20, 2021
@humayraR humayraR modified the milestones: Sprint 3, Sprint 4 Mar 26, 2021
@lucashuy lucashuy self-assigned this Apr 7, 2021
@lucashuy lucashuy mentioned this issue Apr 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucashuy lucashuy

Labels
bug
Projects
None yet
Milestone
Sprint 4
Development

Successfully merging a pull request may close this issue.

Rating frontend lucashuy/gamersnet
2 participants
@lucashuy @humayraR