[Maps] remove 'Top term' metric from ESGeoGridSource editor (elastic#…

…125803) * [Maps] remove 'Top term' metric from ESGeoGridSource editor * simplify comment * update snapshot Co-authored-by: Kibana Machine <[email protected]>
lucasfcosta · Mar 2, 2022 · 02fcad3 · 02fcad3
1 parent e613fb9
commit 02fcad3
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 12 deletions.
diff --git a/...ublic/classes/sources/es_geo_grid_source/__snapshots__/update_source_editor.test.tsx.snap b/...ublic/classes/sources/es_geo_grid_source/__snapshots__/update_source_editor.test.tsx.snap
diff --git a/x-pack/plugins/maps/public/classes/sources/es_geo_grid_source/update_source_editor.tsx b/x-pack/plugins/maps/public/classes/sources/es_geo_grid_source/update_source_editor.tsx
@@ -106,18 +106,18 @@ export class UpdateSourceEditor extends Component<Props, State> {
   };
 
   _getMetricsFilter() {
-    if (this.props.currentLayerType === LAYER_TYPE.HEATMAP) {
-      return (metric: EuiComboBoxOptionOption<AGG_TYPE>) => {
-        // these are countable metrics, where blending heatmap color blobs make sense
-        return metric.value ? isMetricCountable(metric.value) : false;
-      };
-    }
-
-    if (this.props.resolution === GRID_RESOLUTION.SUPER_FINE) {
-      return (metric: EuiComboBoxOptionOption<AGG_TYPE>) => {
-        return metric.value !== AGG_TYPE.TERMS;
-      };
-    }
+    return this.props.currentLayerType === LAYER_TYPE.HEATMAP
+      ? (metric: EuiComboBoxOptionOption<AGG_TYPE>) => {
+          // these are countable metrics, where blending heatmap color blobs make sense
+          return metric.value ? isMetricCountable(metric.value) : false;
+        }
+      : (metric: EuiComboBoxOptionOption<AGG_TYPE>) => {
+          // terms aggregation is not supported with Elasticsearch _mvt endpoint
+          // The goal is to remove GeoJSON ESGeoGridSource implemenation and only have MVT ESGeoGridSource implemenation
+          // First step is to deprecate terms aggregation for ESGeoGridSource
+          // and prevent new uses of terms aggregation for ESGeoGridSource
+          return metric.value !== AGG_TYPE.TERMS;
+        };
   }
 
   _renderMetricsPanel() {