Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] remove 'Top term' metric from ESGeoGridSource editor #125803

Merged
merged 4 commits into from
Feb 23, 2022

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Feb 16, 2022

Part of #124397

This PR updates ESGeoGridSource editor to remove 'Top term' metric from editor. This will prevent users from adding 'Top term' metrics to new and existing layers with ESGeoGridSource. This PR does not effect existing ESGeoGridSource layers with 'Top term'. They will still function as usual. This PR does not prevent users from adding 'Top term' metric to term joins.

@nreese nreese added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.2.0 labels Feb 16, 2022
@nreese nreese requested a review from a team as a code owner February 16, 2022 15:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese nreese requested a review from nickpeihl February 16, 2022 16:03
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

tested in chrome and code review

@nickpeihl
Copy link
Member

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.5MB 2.5MB -46.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit bc35610 into elastic:main Feb 23, 2022
lucasfcosta pushed a commit to lucasfcosta/kibana that referenced this pull request Mar 2, 2022
…125803)

* [Maps] remove 'Top term' metric from ESGeoGridSource editor

* simplify comment

* update snapshot

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants