[top/rbox] Instantiate rbox in top-level #5928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msfschaffner
requested review from
asb,
imphil,
mcy,
moidx,
sjgitty,
sriyerg and
weicaiyang
as code owners
msfschaffner
removed request for
asb,
imphil,
mcy,
moidx,
sjgitty,
sriyerg and
weicaiyang
msfschaffner
force-pushed
the
instantiate-rbox
branch
3 times, most recently
from
ac69de7 to
69c3f03
Compare
tjaychen
reviewed
Apr 5, 2021
| { name: "sysrst_ctrl_aon", | ||
| type: "sysrst_ctrl", | ||
| clock_srcs: {clk_i: "io_div4", clk_aon_i: "aon"}, | ||
| clock_group: "powerup", |
There was a problem hiding this comment.
the clock group probably doesn't need to be "powerup", i would probably move it to the the "secure" category.
@esshiu
@mdhayter
I'm assuming the sysrst_ctrl clock is not something you want software to be able to accidentally disable is that right? This thing being able to run all the time is probably fairly important.
There was a problem hiding this comment.
Oh yeah that's right. Let's move this to secure then.
|
this lgtm. As for the private CI failure, the |
tjaychen
approved these changes
Apr 5, 2021
msfschaffner
force-pushed
the
instantiate-rbox
branch
3 times, most recently
from
e8969ee to
6cee5ba
Compare
msfschaffner
force-pushed
the
instantiate-rbox
branch
4 times, most recently
from
d29869e to
78aa47e
Compare
Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner
force-pushed
the
instantiate-rbox
branch
from
78aa47e to
bc25d5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This instantiates and the
sysrst_ctrlin the top level and fixes a couple of discrepancies that lead to simulation and topgen errors during integration.Note that this PR needs the new topgen features for pinout and pinmux configuration, and is therefore dependent on #5793 which has not been merged yet. This PR therefore looks much bigger than it actually is.
Please only look at the last two commits in this PR. The other commits will be rebased away.